Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forbidden message format #49006

Merged
merged 1 commit into from
Aug 27, 2017
Merged

Fix forbidden message format #49006

merged 1 commit into from
Aug 27, 2017
+16 −6

Conversation

CaoShuFeng
Copy link
Contributor

Before this change:
$ kubectl get pods --as=tom
Error from server (Forbidden): pods "" is forbidden: User "tom" cannot list pods in the namespace "default".
After this change:
$ kubectl get pods --as=tom
Error from server (Forbidden): pods is forbidden: User "tom" cannot list pods in the namespace "default".

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Fix forbidden message format, remove extra ""

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 17, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @CaoShuFeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 17, 2017
@dims
Copy link
Member

dims commented Aug 17, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2017
@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-bazel
/test pull-kubernetes-unit
/test pull-kubernetes-e2e-gce-etcd3

@CaoShuFeng
Copy link
Contributor Author

/assign @liggitt
/assign @deads2k
This is in the scope of SIG-auth.
Thanks.

@liggitt
Copy link
Member

liggitt commented Aug 25, 2017

unit tests that check exact messages need updating (see unit test failures)

LGTM otherwise

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2017
@CaoShuFeng
Copy link
Contributor Author

unit tests that check exact messages need updating (see unit test failures)

I did a little more change after I see the unit tests.
Please take a look again.

liggitt
liggitt reviewed Aug 25, 2017
View reviewed changes
staging/src/k8s.io/apimachinery/pkg/api/errors/errors.go Outdated
@@ -128,6 +128,15 @@ func NewUnauthorized(reason string) *StatusError {

// NewForbidden returns an error indicating the requested action was forbidden
func NewForbidden(qualifiedResource schema.GroupResource, name string, err error) *StatusError {
var message string
res := qualifiedResource.String()
if res == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to check qualifiedResource.Empty() than rely on specific string serialization

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@CaoShuFeng CaoShuFeng force-pushed the is_forbidden branch 2 times, most recently from 2eeaa38 to ab09186 Compare August 26, 2017 02:27
@CaoShuFeng
Fix forbidden message format
ab09186 
Before this change:
 # kubectl get pods --as=tom
 Error from server (Forbidden): pods "" is forbidden: User "tom" cannot list pods in the namespace "default".
After this change:
 # kubectl get pods --as=tom
 Error from server (Forbidden): pods is forbidden: User "tom" cannot list pods in the namespace "default".
@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-unit

@liggitt
Copy link
Member

liggitt commented Aug 26, 2017

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CaoShuFeng, liggitt

Associated issue requirement bypassed by: liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@CaoShuFeng
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-etcd3

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 562d2be into kubernetes:master Aug 27, 2017
@CaoShuFeng CaoShuFeng deleted the is_forbidden branch November 6, 2017 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@zhangxiaoyu-zidif zhangxiaoyu-zidif zhangxiaoyu-zidif approved these changes

Assignees

@liggitt liggitt

@eparis eparis

@deads2k deads2k

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@CaoShuFeng @k8s-ci-robot @dims @liggitt @k8s-github-robot @fejta-bot @zhangxiaoyu-zidif @eparis @deads2k @saad-ali