Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comments on not set node network/inode condition to unknown. #48983

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Added comments on not set node network/inode condition to unknown. #48983

merged 1 commit into from
Jul 18, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Jul 15, 2017 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #48982

Release note:

None

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 15, 2017
@k82cn
Copy link
Member Author

k82cn commented Jul 16, 2017

/cc @gmarek

@k8s-ci-robot k8s-ci-robot requested a review from gmarek July 16, 2017 12:24
@gmarek
Copy link
Contributor

gmarek commented Jul 16, 2017

We certainly don't want to change NetworkUnreachable condition, as it's managed on a control plane level, thus the fact that Node is unreachable doesn't impact our ability to monitor it.

As for InodePressure - I think someone said that they want to get rid of that altogether... @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 16, 2017
@k82cn k82cn force-pushed the set_network_inode_unknown branch from b98a832 to 7e28a2c Compare July 17, 2017 13:37
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2017
@k82cn k82cn changed the title Set node network/inode condition to unknown. Added comments on not set node network/inode condition to unknown. Jul 17, 2017
@k82cn k82cn mentioned this pull request Jul 17, 2017
Closed
@gmarek gmarek assigned gmarek and unassigned smarterclayton and aveshagarwal Jul 18, 2017
@gmarek
Copy link
Contributor

gmarek commented Jul 18, 2017

/retest

@gmarek
Copy link
Contributor

gmarek commented Jul 18, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2017
@gmarek
Copy link
Contributor

gmarek commented Jul 18, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, k82cn

Associated issue: 48982

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2017
feiskyer
feiskyer reviewed Jul 18, 2017
View reviewed changes
pkg/controller/node/nodecontroller.go
v1.NodeOutOfDisk,
v1.NodeMemoryPressure,
v1.NodeDiskPressure,
// We don't change 'NodeInodePressure' condition, as it'll be removed in future.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has NodeInodePressure already been deprecated? If yes, add a link to it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Opened #49103 to confirm whether we can remove it in 1.8 :).

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48983, 49013)

@k8s-github-robot k8s-github-robot merged commit b0b0400 into kubernetes:master Jul 18, 2017
@k82cn k82cn deleted the set_network_inode_unknown branch July 18, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@gmarek gmarek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If node is unreachable, also set NetworkUnavailable/InodePressure to Unknown
7 participants
@k82cn @gmarek @k8s-github-robot @feiskyer @smarterclayton @aveshagarwal @k8s-ci-robot