Loosen label and annotation validation and related tests #4898
Conversation
| } | ||
| totalSize += (int64)(len(k)) + (int64)(len(v)) | ||
| } | ||
| if totalSize > (int64)(util.TotalAnnotationSizeB) { |
There was a problem hiding this comment.
The total allowed annotation size is an attribute of the API, not an attribute of util. I'm trying to keep the util.* plausibly generic - not kubernetes policy in there. This const should move to this file.
There was a problem hiding this comment.
Moved to validation.go
gmarek
force-pushed
the
client2
branch
2 times, most recently
from
fa5e5f8 to
15f6d1f
Compare
|
Friendly ping |
| return true | ||
| } | ||
|
|
||
| const kubeToken string = "[A-Za-z0-9]" |
There was a problem hiding this comment.
just nits:
"token" implies a word, but this is a char.
Suggest "qualNameChar" for what you call kubeToken, "qualNameInnerChar" for extendedKubeToken
There was a problem hiding this comment.
I figured out that we can be even move general, as those definitions will be used for label value format as well. I went with kubeChar and extendedKubeChar.
| const extendedKubeChar string = "[-A-Za-z0-9_.]" | ||
| const qualifiedToken string = "(" + kubeChar + extendedKubeChar + "*)?" + kubeChar | ||
|
|
||
| const LabelValueFmt string = "((" + kubeChar + extendedKubeChar + "*)?" + kubeChar + ")?" |
There was a problem hiding this comment.
Why not define this as "(" + qualifiedToken + ")?" - is that offensive to the purist in you?
|
I'm going to merge this - my last comments are nits and can be done in a followup. |
Loosen label and annotation validation and related tests
No description provided.