Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #48683 upstream release 1.5 #48903

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Automated cherry pick of #48683 upstream release 1.5 #48903

merged 1 commit into from
Jul 13, 2017

Conversation

saad-ali
Copy link
Member

Cherry picks PR #48683 to release-1.5 branch:

@saad-ali saad-ali added this to the v1.5 milestone Jul 13, 2017
@saad-ali saad-ali requested a review from mwielgus July 13, 2017 21:12
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 13, 2017
@saad-ali saad-ali added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 13, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 13, 2017
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 13, 2017
@saad-ali
Copy link
Member Author

CC @abgworrall

@saad-ali
Copy link
Member Author

/approve

@abgworrall
Copy link
Contributor

/lgtm
(although I don't have permissions to lgtm)

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abgworrall, saad-ali
We suggest the following additional approver: mwielgus

Assign the PR to them by writing /assign @mwielgus in a comment when ready.

Associated issue: 48683

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@abgworrall: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm
(although I don't have permissions to lgtm)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saad-ali
Copy link
Member Author

/assign @sttts

@saad-ali saad-ali added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2017
@abgworrall
Copy link
Contributor

pull-kubernetes-e2e-kops-aws will fail after a long timeout until cherrypick #48904 is merged.

@saad-ali saad-ali mentioned this pull request Jul 13, 2017
Merged
@saad-ali saad-ali added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2017
@saad-ali
Copy link
Member Author

All tests are passing accept pull-kubernetes-e2e-kops-aws which depends on #48904 which depends on this PR.

Submit Queue — Required Github CI test is not green: pull-kubernetes-e2e-kops-aws
pull-kubernetes-e2e-kops-aws — Jenkins job triggered.
cla/linuxfoundation — sttts authorized
pull-kubernetes-bazel — Skipped
pull-kubernetes-e2e-gce-bazel — Skipped
pull-kubernetes-e2e-gce-etcd3 — Jenkins job succeeded.
pull-kubernetes-federation-e2e-gce — Skipped
pull-kubernetes-kubemark-e2e-gce — Jenkins job succeeded.
pull-kubernetes-node-e2e — Jenkins job succeeded.
pull-kubernetes-unit — Jenkins job succeeded.
pull-kubernetes-verify — Jenkins job succeeded.

Manually merging to unblock other PRs.

@saad-ali saad-ali merged commit 7d4ee55 into kubernetes:release-1.5 Jul 13, 2017
@k8s-ci-robot
Copy link
Contributor

@saad-ali: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 7e66c2e link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@sttts sttts

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@saad-ali @abgworrall @k8s-github-robot @k8s-ci-robot @sttts @mwielgus