TCPSocket could not be used as it was not checked in validation #4883
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
smarterclayton
added
kind/bug
| @@ -454,6 +454,14 @@ func validateHTTPGetAction(http *api.HTTPGetAction) errs.ValidationErrorList { | |||
| return allErrors | |||
| } | |||
|
|
|||
| func validateTCPSocketAction(tcp *api.TCPSocketAction) errs.ValidationErrorList { | |||
| allErrors := errs.ValidationErrorList{} | |||
| if tcp.Port.IntVal == 0 { | |||
There was a problem hiding this comment.
Do we want a comment about why this does not support named ports? E.g. "Named ports are probably going to be deprecated, so don't handle that here."
There was a problem hiding this comment.
Ill just make it correct - typo on my part
Attempting to use it gave the error "must register one handler". Added more tests for it.
smarterclayton
force-pushed
the
fix_tcpsocket_validation
branch
from
823377c to
d3a5a48
Compare
|
Comment addressed |
|
LGTM |
thockin
added
cla: yes
lgtm
TCPSocket could not be used as it was not checked in validation
|
This raced with #4927 and broke the build. Reverting this one arbitrarily. |
Attempting to use it gave the error "must register one handler".
Added more tests for it.