Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #48402 #48524 upstream release 1.7 #48809

Merged
merged 4 commits into from
Jul 18, 2017
Merged

Automated cherry pick of #48402 #48524 upstream release 1.7 #48809

merged 4 commits into from
Jul 18, 2017

Conversation

wojtek-t
Copy link
Member

Cherry pick of #48524 and #48402 on release-1.7.

#48524 : fix udp service blackhole problem when number of backends changes from 0 to non-0
#48402 : Local storage teardown fix

ianchakeres and others added 4 commits July 12, 2017 14:34
@ianchakeres @wojtek-t
Fixes bind-mount teardown failure with non-mount point Local volumes
f8c28b5 
Added IsNotMountPoint method to mount utils (pkg/util/mount/mount.go)
Added UnmountMountPoint method to volume utils (pkg/volume/util/util.go)
Call UnmountMountPoint method from local storage (pkg/volume/local/local.go)
IsLikelyNotMountPoint behavior was not modified, so the logic/behavior for UnmountPath is not modified
@freehan @wojtek-t
flush conntrack entry for udp service when # of backend changes from …
78fe3c2 
…0 to non-0
@freehan @wojtek-t
refactor updateEndpointMap and updateServiceMap results
eca6a95
@freehan @wojtek-t
fix unit tests
1c75818
@wojtek-t wojtek-t added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 12, 2017
@wojtek-t wojtek-t requested review from freehan and ianchakeres July 12, 2017 12:38
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2017
This was referenced Jul 12, 2017
Merged
Merged
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2017
@wojtek-t wojtek-t assigned freehan and ianchakeres and unassigned tmrts and jingxu97 Jul 12, 2017
@freehan
Copy link
Contributor

freehan commented Jul 12, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2017
@wojtek-t
Copy link
Member Author

/retest

@wojtek-t wojtek-t added this to the v1.7 milestone Jul 13, 2017
@ianchakeres
Copy link
Contributor

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, ianchakeres, wojtek-t

Associated issue: 48524

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member Author

/retest

@msau42
Copy link
Member

msau42 commented Jul 13, 2017

I had added issue #48331 to the 1.7 release notes known issues. It should be removed from the known issues when this patch goes out.

@wojtek-t
Copy link
Member Author

I'm temporarily adding do-not-merge label due to some problems with release branch. Will remove it once we figure it out.

@wojtek-t wojtek-t added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 14, 2017
@ianchakeres
Copy link
Contributor

/test pull-kubernetes-federation-e2e-gce

@wojtek-t wojtek-t removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 17, 2017
@wojtek-t
Copy link
Member Author

OK - this is good to go. Removing do-not-merge label.

@wojtek-t
Copy link
Member Author

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e76b450 into kubernetes:release-1.7 Jul 18, 2017
@arunmk
Copy link

arunmk commented Jul 19, 2017

@wojtek-t I see this fix is in 1.8.0-alpha.2 version. Is there a plan to bring this to 1.7.x?

@wojtek-t
Copy link
Member Author

@arunmk - this PR cherrypicked it to 1.7 branch. So yes - it will be part of 1.7.2

@liggitt liggitt mentioned this pull request Sep 14, 2017
Closed
52 tasks
@wojtek-t wojtek-t deleted the automated-cherry-pick-of-#48402-#48524-upstream-release-1.7 branch February 1, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan Awaiting requested review from freehan

@ianchakeres ianchakeres Awaiting requested review from ianchakeres

Assignees

@freehan freehan

@ianchakeres ianchakeres

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
9 participants
@wojtek-t @freehan @ianchakeres @k8s-github-robot @msau42 @arunmk @tmrts @jingxu97 @k8s-ci-robot