Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that image tags contain only allowed characters. #48808

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Make sure that image tags contain only allowed characters. #48808

merged 1 commit into from
Jul 17, 2017
+52 −10

Conversation

kad
Copy link
Member

@kad kad commented Jul 12, 2017

What this PR does / why we need it:
Version strings can contain symbols that are not allowed
as part of image tags. Replace those with underscores.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Part of work related to usage of CI images which has versions like "v1.8.0-alpha.1.910+5ca03d674e1495" but image tags in registry are "v1.8.0-alpha.1.910_5ca03d674e1495"

Attn @luxas

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @kad. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2017
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 12, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 12, 2017
@kad kad force-pushed the safe-docker-tags branch from 2c0d79d to 5c3f4a9 Compare July 12, 2017 11:49
@kad kad mentioned this pull request Jul 12, 2017
Merged
@kad kad force-pushed the safe-docker-tags branch from 5c3f4a9 to 1624b31 Compare July 12, 2017 16:15
@luxas
Copy link
Member

luxas commented Jul 12, 2017

argh, please look at my comments in #48806 that affect this PR...

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2017
@kad kad force-pushed the safe-docker-tags branch from 1624b31 to f521ded Compare July 13, 2017 11:48
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2017
@kad
Copy link
Member Author

kad commented Jul 13, 2017

Rebased, addressed comments.

@luxas
Copy link
Member

luxas commented Jul 17, 2017

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2017
@luxas
Copy link
Member

luxas commented Jul 17, 2017

@kad this needs a bazel update

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2017
@kad
Copy link
Member Author

kad commented Jul 17, 2017

@luxas updated, tests now passing

@luxas
Copy link
Member

luxas commented Jul 17, 2017

@kad please squash

@kad
Make sure that image tags contain only allowed characters.
5a4d560 
Version strings can contain symbols that are not allowed
as part of image tags. Replace those with underscores.
@kad kad force-pushed the safe-docker-tags branch from 31a5df8 to 5a4d560 Compare July 17, 2017 20:54
@luxas
Copy link
Member

luxas commented Jul 17, 2017

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2017
@luxas
Copy link
Member

luxas commented Jul 17, 2017

Part of: kubernetes/kubeadm#337 (but doesn't fix everything)
/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kad, luxas

Associated issue requirement bypassed by: luxas

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49017, 45440, 48384, 45894, 48808)

@k8s-github-robot k8s-github-robot merged commit 290a0ed into kubernetes:master Jul 17, 2017
@lixiaobing1 lixiaobing1 mentioned this pull request Jul 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kad @k8s-ci-robot @luxas @k8s-github-robot @justinsb