Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround docker-wait freeze with 17.06.0 #48762

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Workaround docker-wait freeze with 17.06.0 #48762

merged 1 commit into from
Jul 11, 2017
+7 −1

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jul 11, 2017 •
edited
Loading

Workaround moby/moby#33948 and maybe fix kops timeouts.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 11, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2017
@sttts sttts assigned fejta and wojtek-t and unassigned lavalamp and ixdy Jul 11, 2017
@sttts sttts added priority/P0 kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jul 11, 2017
@dims
Copy link
Member

dims commented Jul 11, 2017

@sttts there was one more PR in the same area, not sure if that would help with the kops problem though - 546cb0c

@sttts
Copy link
Contributor Author

sttts commented Jul 11, 2017

@dims looks like a race in the other PR.

@sttts sttts mentioned this pull request Jul 11, 2017
Closed
@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 11, 2017
@dims
Copy link
Member

dims commented Jul 11, 2017

Ack @sttts

@wojtek-t
Copy link
Member

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, wojtek-t

Associated issue requirement bypassed by: wojtek-t

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2017
This was referenced Jul 11, 2017
Merged
Merged
@spiffxp
Copy link
Member

spiffxp commented Jul 11, 2017

/remove-priority P0
/priority critical-urgent
@k8s-oncall I believe this needs to be manually merged, the thinking is this fixes whatever is causing pull-kubernetes-e2e-kops-aws to timeout

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/P0 labels Jul 11, 2017
@sttts
Copy link
Contributor Author

sttts commented Jul 11, 2017

Doesn't look good.

@spiffxp
Copy link
Member

spiffxp commented Jul 11, 2017

ref #48478

@humblec humblec mentioned this pull request Jul 11, 2017
Merged
@fejta
Copy link
Contributor

fejta commented Jul 11, 2017

Theoretically if this fixes things then we shouldn't need to manually merge?

@krousey
Copy link
Contributor

krousey commented Jul 11, 2017

/test pull-kubernetes-federation-e2e-gce

@spiffxp
Copy link
Member

spiffxp commented Jul 11, 2017

@fejta I want to agree with you and be proven wrong, fingers crossed

@pmichali pmichali mentioned this pull request Jul 11, 2017
Merged
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 11, 2017 •
edited
Loading

@sttts: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e 1f40e75 link /test pull-kubernetes-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@krousey krousey merged commit 339932f into kubernetes:master Jul 11, 2017
@krousey
Copy link
Contributor

krousey commented Jul 11, 2017 •
edited
Loading

Manually merging so we don't wait on anymore flakes. It did pass the aws test, which is the major blocker.

@cblecker cblecker mentioned this pull request Jul 11, 2017
Closed
@sttts
Copy link
Contributor Author

sttts commented Jul 12, 2017

Do we need this also on the 1.7 branch?

@wojtek-t
Copy link
Member

@sttts - I'm creating a cherrypick on 1.7.

@wojtek-t
Copy link
Member

#48804 is out for review

@wojtek-t wojtek-t mentioned this pull request Jul 12, 2017
Merged
wojtek-t added a commit that referenced this pull request Jul 12, 2017
@wojtek-t
Merge pull request #48804 from wojtek-t/automated-cherry-pick-of-#487…
e770c60 
…62-upstream-release-1.7

Automated cherry pick of #48762 upstream release 1.7
@saad-ali saad-ali mentioned this pull request Jul 13, 2017
Merged
saad-ali added a commit that referenced this pull request Jul 14, 2017
@saad-ali
Merge pull request #48904 from saad-ali/automated-cherry-pick-of-#487…
824f1b2 
…62-upstream-release-1.5

Automated cherry pick of #48762 upstream release 1.5
@cblecker cblecker mentioned this pull request Jul 14, 2017
Closed
This was referenced Jul 19, 2017
Closed
Merged
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

k8s-github-robot pushed a commit that referenced this pull request Jul 19, 2017
Merge pull request #49214 from spiffxp/automated-cherry-pick-of-#4876…
c9dc04b 
…2-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #48762

Cherry pick of #48762 on release-1.6.

#48762: Workaround docker-wait freeze with 17.06.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fejta fejta

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.