Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEAD Automated cherry pick of #48168 #48277 #48726

Closed
wants to merge 2 commits into from
Closed

DEAD Automated cherry pick of #48168 #48277 #48726

wants to merge 2 commits into from

Conversation

abgworrall
Copy link
Contributor

@abgworrall abgworrall commented Jul 10, 2017 •
edited
Loading

Cherry pick of #48168 #48277 on release-1.7.

#48168: Log the OS images used during cluster creation
#48277: Write output into the correct dir

On GCP platforms, e2e testing now logs which OS images the cluster was found to have.

NONE

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abgworrall
We suggest the following additional approver: fabianofranz

Assign the PR to them by writing /assign @fabianofranz in a comment when ready.

Associated issue: 48168

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Jul 10, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @abgworrall. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 10, 2017
@tallclair
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2017
@k8s-github-robot k8s-github-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 10, 2017
@nilebox nilebox mentioned this pull request Jul 11, 2017
Merged
@abgworrall
Copy link
Contributor Author

/retest

@fabianofranz
Copy link
Contributor

/test pull-kubernetes-unit

@abgworrall
Copy link
Contributor Author

/retest

1 similar comment
@abgworrall
Copy link
Contributor Author

/retest

@abgworrall abgworrall mentioned this pull request Jul 12, 2017
Closed
@abgworrall
Copy link
Contributor Author

I messed up the underlying branch for this PR, and can't rebase it to pickup a fix for the unit test error. I'll close this and start again.

@abgworrall abgworrall changed the title Automated cherry pick of #48168 #48277 DEAD Automated cherry pick of #48168 #48277 Jul 12, 2017
@abgworrall abgworrall force-pushed the automated-cherry-pick-of-#48168-#48277-upstream-release-1.7 branch from 9ffed10 to ff2287d Compare July 12, 2017 17:00
@abgworrall abgworrall closed this Jul 12, 2017
@abgworrall abgworrall deleted the automated-cherry-pick-of-#48168-#48277-upstream-release-1.7 branch July 12, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabianofranz fabianofranz

@kow3ns kow3ns

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abgworrall @k8s-github-robot @k8s-ci-robot @tallclair @fabianofranz @kow3ns