Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy/userspace: honor listen IP address as host IP if given #48613

Merged
merged 1 commit into from
Jul 12, 2017
Merged

proxy/userspace: honor listen IP address as host IP if given #48613

merged 1 commit into from
Jul 12, 2017
+9 −3

Conversation

dcbw
Copy link
Member

@dcbw dcbw commented Jul 7, 2017 •
edited
Loading

Allows the proxier to be used on an interface that's not the default route,
otherwise hostIP gets set to the default route interface even if that's
not what the user intended.

If listen IP isn't given, falls back to previous behavior.

To allow the userspace proxy to work correctly on multi-interface hosts when using the non-default-route interface, you may now set the `bindAddress` configuration option to an IP address assigned to a network interface.  The proxy will use that IP address for any required NAT operations instead of the IP address of the interface which has the default route.

@kubernetes/sig-network-misc @thockin @wojtek-t

@dcbw
proxy/userspace: honor listen IP address as host IP if given
8a58f62 
Allows the proxier to be used on an interface that's not the default route,
otherwise hostIP gets set to the default route interface even if that's
not what the user intended.

If listen IP isn't given, falls back to previous behavior.
@dcbw dcbw added area/kube-proxy sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jul 7, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jul 7, 2017
@dcbw
Copy link
Member Author

dcbw commented Jul 7, 2017

/test pull-kubernetes-federation-e2e-gce issue #48623

@thockin
Copy link
Member

thockin commented Jul 7, 2017

This needs a release note

@thockin
Copy link
Member

thockin commented Jul 7, 2017

/approve no-issue
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 7, 2017
@dcbw
Copy link
Member Author

dcbw commented Jul 7, 2017

@thockin is there a way to figure out why the GCE federation tests are failing? No artifacts get downloaded so it's pretty hard to see why the gce-federation-up script exits.

@dcbw dcbw removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 7, 2017
@dcbw
Copy link
Member Author

dcbw commented Jul 7, 2017

Removing do-not-merge now that there is a release note and label.

@cmluciano
Copy link

/retest

noted that the federation tests were flaky around this time period

@pmichali
Copy link
Contributor

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, pmichali, thockin

Associated issue requirement bypassed by: thockin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dcbw
Copy link
Member Author

dcbw commented Jul 11, 2017

/test pull-kubernetes-federation-e2e-gce

helpers.go:119] error: Couldn't get clientset to create RBAC roles in the host cluster: Get https://35.188.92.115/api: dial tcp 35.188.92.115:443: i/o timeout

@dcbw
Copy link
Member Author

dcbw commented Jul 11, 2017

/test pull-kubernetes-e2e-kops-aws

@dcbw
Copy link
Member Author

dcbw commented Jul 11, 2017

/test pull-kubernetes-e2e-kops-aws issue #48780

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47232, 48625, 48613, 48567, 39173)

@k8s-github-robot k8s-github-robot merged commit 923ef03 into kubernetes:master Jul 12, 2017
@dcbw dcbw mentioned this pull request Jul 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

@pmichali pmichali

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dcbw @thockin @cmluciano @pmichali @k8s-github-robot @smarterclayton @k8s-ci-robot