Make RESTful operations return 404 Not Found when the target resource does not exist. #486
+433
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // RESTStorage is a generic interface for RESTful storage services | ||
| // Storages whicih are exported to the RESTful API of apiserver need to implement this interface. |
There was a problem hiding this comment.
"Resources which are exported ..."
|
PTAL |
|
LGTM |
|
I'm OK with this, as long as there's the understanding that we'll change it to an error type that carries a suggested HTTP response code with it. I don't want to make an error type for every possible return value and use a switch to decide what to return. I actually was moving in that direction with the api.Status struct, which has a "Code" field for that purpose, and the client already has a StatusError type... Please squash before we commit, though! |
|
@lavalamp - agree, an error associated with a "rest storage" interface should logically match REST error conditions as much as possible. |
does not exist. In the original implementation, GET, DELETE and PUT operations on non-existent resources used to return 500 but not 404.
|
Squashed. |
lavalamp
added a commit
that referenced
this pull request
Jul 18, 2014
Make RESTful operations return 404 Not Found when the target resource does not exist.
|
Thanks for the change! |
vishh
added a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
Specify that stats writing continued in error.
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
Remove kustomize
b3atlesfan
pushed a commit
to b3atlesfan/kubernetes
that referenced
this pull request
Feb 5, 2021
Makefile: Disable static builds of flanneld
jsafrane
pushed a commit
to jsafrane/kubernetes
that referenced
this pull request
Mar 1, 2021
…rry-pick-481-to-release-4.6 Bug 1907461: kubelet: do not rerun init containers if any main containers have status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original implementation, GET, DELETE and PUT operations on
non-existent resources used to return 500 but not 404.