Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Service Affinity for OpenStack cloudprovider #48501

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Enable Service Affinity for OpenStack cloudprovider #48501

merged 1 commit into from
Jul 6, 2017

Conversation

FengyunPan
Copy link

Fix issue: #48500
Kubernetes's OpenStack cloudprovider can't set persistence to "SOURCE_IP"

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

Hi @FengyunPan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 5, 2017
@FengyunPan FengyunPan force-pushed the enable-ServiceAffinity branch from 1cb5f57 to bad36d3 Compare July 5, 2017 13:52
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 5, 2017
dims
dims reviewed Jul 5, 2017
View reviewed changes
pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go Outdated
@@ -546,15 +546,6 @@ func (lbaas *LbaasV2) createLoadBalancer(service *v1.Service, name string) (*loa
return loadbalancer, nil
}

func stringInArray(x string, list []string) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an unrelated change. Can you please file as a separate PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.

@dims
Copy link
Member

dims commented Jul 5, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 5, 2017
Enable Service Affinity for OpenStack cloudprovider.
6ee0578 
Fix issue: kubernetes#48500
Kubernetes's OpenStack cloudprovider can't set LB's persistence
to "SOURCE_IP".
@FengyunPan FengyunPan force-pushed the enable-ServiceAffinity branch from bad36d3 to 6ee0578 Compare July 6, 2017 01:28
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2017
@anguslees
Copy link
Member

Oops ;)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2017
@dims
Copy link
Member

dims commented Jul 6, 2017

/approve
/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FengyunPan, anguslees, dims

Associated issue: 48500

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Jul 6, 2017

/test pull-kubernetes-e2e-gce-etcd3

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9dd6a93 into kubernetes:master Jul 6, 2017
@cblecker cblecker mentioned this pull request Jul 6, 2017
Closed
dims pushed a commit to dims/kubernetes that referenced this pull request Feb 8, 2018
Merge pull request kubernetes#48501 from FengyunPan/enable-ServiceAff…
9d770f3 
…inity

Automatic merge from submit-queue

Enable Service Affinity for OpenStack cloudprovider

Fix issue: kubernetes#48500
Kubernetes's OpenStack cloudprovider can't set persistence to "SOURCE_IP"

**Release note**:
```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims

Assignees

@dims dims

@anguslees anguslees

@NickrenREN NickrenREN

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FengyunPan @k8s-ci-robot @dims @anguslees @k8s-github-robot @NickrenREN