Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker wait for macos #48403

Closed
wants to merge 1 commit into from
Closed

Fix docker wait for macos #48403

wants to merge 1 commit into from

Conversation

johscheuer
Copy link
Contributor

What this PR does / why we need it:
This PR checks if the container exist and if not don't wait for it. This allows for MacOS users to build kubernetes again. I tested it on my MacOS:

Darwin .... 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #48342

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @johscheuer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 2, 2017
@dims
Copy link
Member

dims commented Jul 3, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2017
@dims
Copy link
Member

dims commented Jul 3, 2017

/assign @jbeda
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dims, johscheuer
We suggest the following additional approver: jbeda

Assign the PR to them by writing /assign @jbeda in a comment when ready.

Associated issue: 48342

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 3, 2017
@dims
Copy link
Member

dims commented Jul 6, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 6, 2017
@dims
Copy link
Member

dims commented Jul 6, 2017

@jbeda can you please remove the do-not-merge label and /approve as well when you get a chance.

@ianchakeres
Copy link
Contributor

Here's the related issue on docker, docker/for-mac#1714

@ianchakeres
Copy link
Contributor

I recently experienced an issue with the test suite pull-kubernetes-e2e-kops-aws #47999

If the docker version was updated in the e2e-kops-aws test environment, it might be related to this issue.

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/47999/pull-kubernetes-e2e-kops-aws/34000/

Build timed out (after 90 minutes). Marking the build as failed. Build was aborted W0710 14:40:42.986] build/../build/common.sh: line 385: 27254 Terminated "${DOCKER[@]}" wait "$1" > /dev/null 2>&1

@ianchakeres ianchakeres mentioned this pull request Jul 11, 2017
Merged
@sttts
Copy link
Contributor

sttts commented Jul 11, 2017

This should be race free: #48762

@wojtek-t
Copy link
Member

Yeah - I vote for #48762. I'm closing this one in favor of the other one.

@wojtek-t wojtek-t closed this Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

@jbeda jbeda

@spxtr spxtr

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building k8s 1.7.0 use docker on mac failed
9 participants
@johscheuer @k8s-ci-robot @dims @k8s-github-robot @ianchakeres @sttts @wojtek-t @jbeda @spxtr