Print grafana proxy address in kube-up.sh. #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -868,7 +868,7 @@ function setup-monitoring-firewall { | |||
| done | |||
| if [[ ${grafana_host} != *"<"* ]]; then | |||
There was a problem hiding this comment.
cc @vishh
I found the title of this PR a title deceptive even if the change is cool, because it's not "fixing" the address, so much as changing it to go through the proxy.
I would remove lines 859-867. We already have "Wait for the monitoring dashboard to be online."
There was a problem hiding this comment.
+1 to what @zmerlynn said. Since we don't use the grafana_host anymore, that logic can be deleted.
zmerlynn
changed the title
|
Thanks for the fix @jszczepkowski!!!! |
Print grafana address print in kube-up.sh. Resolved kubernetes#4721.
jszczepkowski
force-pushed
the
grafana-address
branch
from
0f6ff23 to
7763570
Compare
|
Comments applied. |
|
LGTM |
vishh
added a commit
that referenced
this pull request
Feb 27, 2015
Print grafana proxy address in kube-up.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed grafana address print by kube-up.sh. Resolved #4721.