Fix share name generation in azure file provisioner. #48326
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XS
|
Hi @karataliu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/retest |
1 similar comment
|
/retest |
brendandburns
added
release-note
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, karataliu Associated issue requirement bypassed by: brendandburns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/retest |
|
Automatic merge from submit-queue |
|
/sig azure |
…8326-upstream-release-1.7-1506563999 Automatic merge from submit-queue. Automated cherry pick of #48326 **What this PR does / why we need it**: Azure file share name has a length limit of 63, but currently the code is using data volume's limit 75. **Which issue this PR fixes** cherry-pick fix of #48326 With current implementation, when the cluster name is long, the resulting file share name could have a length of 75. Also function GenerateVolumeName would produce double '-' when clusterName containing '-' is to be truncated. In both cases, service would reject the creating file share request. **Special notes for your reviewer**: Please refer to: https://docs.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-shares--directories--files--and-metadata#share-names Share names must be from 3 through 63 characters long. The name cannot contain two consecutive hyphens. **Release note**: ``` Fix the issue: could not create an azure file when k8s cluster name lenght > 15 ```
What this PR does / why we need it:
Azure file share name has a length limit of 63, but currently the code is using data volume's limit 75.
Which issue this PR fixes
With current implementation, when the cluster name is long, the resulting file share name could have a length of 75.
Also function
GenerateVolumeNamewould produce double '-' when clusterName containing '-' is to be truncated.In both cases, service would reject the creating file share request.
Special notes for your reviewer:
Please refer to:
https://docs.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-shares--directories--files--and-metadata#share-names
@rootfs @colemickens
Release note: