Validate api version in kubectl --patch and --override #4819
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedanese
force-pushed
the
validate-api-version
branch
2 times, most recently
from
22bf9d7 to
4bd5543
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
mikedanese
force-pushed
the
validate-api-version
branch
from
4bd5543 to
e7ab977
Compare
|
CLAs look good, thanks! |
|
LGTM. Will merge once CI passes. |
vishh
added
the
lgtm
|
|
|
Too be expected. This would break ./hack/test-cmd.sh until #4793 is merged, but may be fixed in master. I'll rebase. |
mikedanese
force-pushed
the
validate-api-version
branch
3 times, most recently
from
a026002 to
e644fce
Compare
|
This is good to go. |
|
Rerunning travis since it's been a few days since the last run. Will merge when it comes back green. |
mikedanese
force-pushed
the
validate-api-version
branch
from
e644fce to
25fac68
Compare
bgrant0607
added a commit
that referenced
this pull request
Mar 2, 2015
Validate api version in kubectl --patch and --override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InterfacesFor() returns an error when the apiVersion is not found where CodecFor does not. This breaks ./hack/test-cmd.sh until #4793 is merged. Also related to #4771.