Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GCE ContainerVM to container-vm-v20170627 #48159

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Bump GCE ContainerVM to container-vm-v20170627 #48159

merged 1 commit into from
Jun 28, 2017

Conversation

zmerlynn
Copy link
Member

@zmerlynn zmerlynn commented Jun 27, 2017 •
edited
Loading

Remove the built-in kubelet (finally), pick up security fixes.

Bump GCE ContainerVM to container-vm-v20170627

Not really associated issue: #48163

@zmerlynn
Bump GCE ContainerVM to container-vm-v20170627
903bc64 
Remove the built-in kubelet (finally), pick up security fixes.
@zmerlynn zmerlynn requested review from timstclair and dchen1107 June 27, 2017 23:21
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 27, 2017
@zmerlynn zmerlynn assigned timstclair and dchen1107 and unassigned gmarek and jszczepkowski Jun 27, 2017
@timstclair
Copy link

/lgtm

Thanks Zach!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2017
@zmerlynn
Copy link
Member Author

/approve no-issue

@dchen1107 dchen1107 added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jun 27, 2017
@dchen1107
Copy link
Member

/lgtm

@dchen1107
Copy link
Member

cc/ @freehan @bowei

@dchen1107 dchen1107 added this to the v1.7 milestone Jun 27, 2017
@zmerlynn
Copy link
Member Author

Hm, can someone else try /approve no-issue? Can I not do that to my own PR?

@timstclair
Copy link

/approve no-issue

@timstclair
Copy link

/approve no-issue

hmm, no idea why that didn't work...

@zmerlynn zmerlynn mentioned this pull request Jun 27, 2017
Closed
@zmerlynn
Copy link
Member Author

Opened #48163, which will help me actually get this approved. :p

@zmerlynn
Copy link
Member Author

/approve

1 similar comment
@dchen1107
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, timstclair, zmerlynn

Associated issue: 48163

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2017
@zmerlynn
Copy link
Member Author

Whew, it was touch-and-go for a moment there.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48118, 48159)

@k8s-github-robot k8s-github-robot merged commit 0ce5809 into kubernetes:master Jun 28, 2017
@zmerlynn zmerlynn mentioned this pull request Jun 28, 2017
Merged
caesarxuchao added a commit that referenced this pull request Jun 28, 2017
@caesarxuchao
Merge pull request #48210 from zmerlynn/automated-cherry-pick-of-#481…
8bf891d 
…59-upstream-release-1.7

Automated cherry pick of #48159
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timstclair timstclair Awaiting requested review from timstclair

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@freehan freehan

@timstclair timstclair

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
10 participants
@zmerlynn @timstclair @dchen1107 @k8s-github-robot @k8s-cherrypick-bot @freehan @gmarek @caesarxuchao @jszczepkowski @k8s-ci-robot