Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GZip openapi schema if accepted by client #48151

Merged
merged 2 commits into from
Jul 1, 2017
Merged

GZip openapi schema if accepted by client #48151

merged 2 commits into from
Jul 1, 2017

Conversation

apelisse
Copy link
Member

@apelisse apelisse commented Jun 27, 2017 •
edited
Loading

What this PR does / why we need it: Uses gzip "Accept-Encoding" flag rather than specific path to download gzipped openapi schema.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #48375

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2017
@apelisse apelisse changed the title Accept encoding gzip Openapi schema: "Accept-encoding: gzip" rather than different filepath Jun 27, 2017
@apelisse apelisse added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 27, 2017
@k8s-github-robot k8s-github-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 27, 2017
@mbohlool
Copy link
Contributor

We definitely want to add this to release note. Also we cannot just remove .gz file from 1.8 as we have it in 1.7 and a user can reply on it so I suggest we keep the file for one release and deprecate it in 1.9 unless you feel strongly about this, in that case we can discuss it.

@apelisse apelisse force-pushed the accept-encoding-gzip branch from 3ef276a to d02a2eb Compare June 27, 2017 22:46
@apelisse apelisse added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 27, 2017
@apelisse apelisse changed the title Openapi schema: "Accept-encoding: gzip" rather than different filepath GZip openapi schema if accepted by client Jun 27, 2017
@apelisse apelisse force-pushed the accept-encoding-gzip branch from d02a2eb to f617df7 Compare June 27, 2017 22:55
@apelisse
Copy link
Member Author

Let's keep the link. PTAL

@mbohlool
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2017
@apelisse apelisse assigned deads2k and unassigned mbohlool Jun 28, 2017
@apelisse
Copy link
Member Author

@deads2k Can you have a look?

@deads2k
Copy link
Contributor

deads2k commented Jun 30, 2017

/lgtm

@apelisse apelisse assigned thockin and unassigned deads2k Jun 30, 2017
@thockin
Copy link
Member

thockin commented Jun 30, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apelisse, deads2k, mbohlool, thockin

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Jul 1, 2017 •
edited by rmmh
Loading

Automatic merge from submit-queue (batch tested with PRs 47918, 47964, 48151, 47881, 48299)

@k8s-github-robot k8s-github-robot merged commit 19724f0 into kubernetes:master Jul 1, 2017
@mbohlool mbohlool mentioned this pull request Aug 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbohlool mbohlool

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openapi: Simplify gzip encoding for openapi endpoint
6 participants
@apelisse @mbohlool @deads2k @thockin @k8s-github-robot @k8s-ci-robot