Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip errors when unregistering juju kubernetes-workers #48144

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Skip errors when unregistering juju kubernetes-workers #48144

merged 1 commit into from
Jul 5, 2017

Conversation

ktsakalozos
Copy link
Contributor

What this PR does / why we need it: When removing a kubernetes node from using Juju and for some reason kubernetes master fails we should not error the node, instead we should proceed with the removal of the node and the master will recognise that node as unavailable because it will fail heartbeats.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/300

Special notes for your reviewer:

Release note:

Clean decommission of Juju kubernetes worker units

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @ktsakalozos. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 27, 2017
@lazypower
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2017
lazypower
lazypower reviewed Jun 27, 2017
View reviewed changes
cluster/juju/layers/kubernetes-worker/reactive/kubernetes_worker.py Outdated
if os.path.isfile(kubeconfig_path):
kubectl('delete', 'node', gethostname())
except CalledProcessError:
hookenv.log('Failed to get unregister node.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Failed to get/Failed to/

@ktsakalozos
Copy link
Contributor Author

/retest

This was referenced Jul 4, 2017
Merged
Merged
Merged
@ktsakalozos ktsakalozos force-pushed the bug/worker-termination branch from 4fe950c to 63e2f37 Compare July 5, 2017 12:55
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2017
@ktsakalozos ktsakalozos force-pushed the bug/worker-termination branch from 63e2f37 to 90a5793 Compare July 5, 2017 13:01
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2017
@Cynerva
Copy link
Contributor

Cynerva commented Jul 5, 2017

/assign @Cynerva
/retest

@Cynerva
Copy link
Contributor

Cynerva commented Jul 5, 2017

/lgtm
/approve no-issue

Looks good, thanks @ktsakalozos 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, ktsakalozos

Associated issue requirement bypassed by: Cynerva

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48399, 48450, 48144)

@k8s-github-robot k8s-github-robot merged commit 40a2131 into kubernetes:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazypower lazypower lazypower left review comments

Assignees

@Cynerva Cynerva

@mbruzek mbruzek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

worker stop hook fails when node goes away
6 participants
@ktsakalozos @k8s-ci-robot @lazypower @Cynerva @k8s-github-robot @mbruzek