Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #44058 #48112

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Automated cherry pick of #44058 #48112

merged 2 commits into from
Jun 27, 2017

Conversation

caesarxuchao
Copy link
Member

Cherry pick of #44058 on release-1.7.

#44058: revert 45764

Chao Xu added 2 commits June 26, 2017 15:38
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2017
@k8s-github-robot k8s-github-robot added this to the v1.7 milestone Jun 26, 2017
@k8s-github-robot k8s-github-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2017
@caesarxuchao
Copy link
Member Author

@liggitt @Kargakis could you take a look at this cherry-pick? Thanks.

@liggitt
Copy link
Member

liggitt commented Jun 26, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2017
@janetkuo
Copy link
Member

/lgtm

@janetkuo
Copy link
Member

/approve

@caesarxuchao
Copy link
Member Author

A k8s-bot bug? Janet is an approver.

@caesarxuchao caesarxuchao added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, janetkuo, liggitt

Associated issue: 44058

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@janetkuo
Copy link
Member

janetkuo commented Jun 27, 2017 •
edited
Loading

@k8s-merge-robot was just slow (took 30+ min to respond 😕)

@liggitt
Copy link
Member

liggitt commented Jun 27, 2017

/retest

@dchen1107
Copy link
Member

/test pull-kubernetes-federation-e2e-gce

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b4d1ea1 into kubernetes:release-1.7 Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

Assignees

@liggitt liggitt

@0xmichalis 0xmichalis

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
9 participants
@caesarxuchao @liggitt @janetkuo @k8s-github-robot @dchen1107 @0xmichalis @deads2k @nikhiljindal @k8s-ci-robot