Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry finding RBAC version if not found in discovery cache #48077

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Retry finding RBAC version if not found in discovery cache #48077

merged 1 commit into from
Jun 26, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 26, 2017 •
edited by enisoc
Loading

Alternate to #47995

xref #47977

The caching discovery client can indicate whether it used fresh discovery data. kubefed init should invalidate and recheck if it doesn't find an RBAC API group

`kubefed init` correctly checks for RBAC API enablement.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2017
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 26, 2017
@liggitt liggitt mentioned this pull request Jun 26, 2017
Closed
@liggitt liggitt changed the title Retry finding RBAC version if not found in discovery cache Retry finding RBAC version if not found in stale discovery cache Jun 26, 2017
@liggitt liggitt changed the title Retry finding RBAC version if not found in stale discovery cache Retry finding RBAC version if not found in discovery cache Jun 26, 2017
@madhusudancs
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2017
@nikhiljindal nikhiljindal removed their assignment Jun 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, madhusudancs

Associated issue: 47977

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 26, 2017
@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 26, 2017
@liggitt liggitt added this to the v1.7 milestone Jun 26, 2017
@liggitt liggitt added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 26, 2017
@liggitt
Copy link
Member Author

liggitt commented Jun 26, 2017

decision in burndown meeting was to fix client-side use of cache and pick into 1.6/1.7

This was referenced Jun 26, 2017
Closed
Merged
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44058, 48085, 48077, 48076, 47823)

@k8s-github-robot k8s-github-robot merged commit babd565 into kubernetes:master Jun 26, 2017
dchen1107 added a commit that referenced this pull request Jun 27, 2017
@dchen1107
Merge pull request #48100 from liggitt/automated-cherry-pick-of-#4807…
e05853d 
…7-upstream-release-1.7

Automated cherry pick of #48077
k8s-github-robot pushed a commit that referenced this pull request Jun 27, 2017
Merge pull request #48101 from liggitt/automated-cherry-pick-of-#4807…
b1c7641 
…7-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #48077

Cherry pick of #48077 on release-1.6.

#48077: Retry finding RBAC version if not found in discovery cache
@liggitt liggitt deleted the kubefed-discovery-cache branch July 4, 2017 22:57
@lachie83 lachie83 mentioned this pull request Jul 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@madhusudancs madhusudancs

@shashidharatd shashidharatd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @madhusudancs @k8s-github-robot @shashidharatd @nikhiljindal @k8s-ci-robot