Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a failsafe for etcd not returning a connection string #48054

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Add a failsafe for etcd not returning a connection string #48054

merged 1 commit into from
Jun 27, 2017

Conversation

ktsakalozos
Copy link
Contributor

What this PR does / why we need it: Removing a kubernetes-master will fail as described on this issue: https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/311

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/311

Special notes for your reviewer: This is a two liner defensive code. I am not totally sold on this patch. I might not be the right place to address the above issue. However, solving the problem on the etcd side and updating the interface scope to be unit (as suggested) seems much more involving.

Release note:

Fix error when removing juju kubernetes-master unit

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @ktsakalozos. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 26, 2017
@ktsakalozos ktsakalozos mentioned this pull request Jun 26, 2017
Merged
@eparis
Copy link
Contributor

eparis commented Jun 26, 2017

/unassign
I can approve after an technical discussions, but I don't understand juju or why we need this to review.

@lazypower
Copy link
Contributor

/approve
/approve-no-issue
/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2017
@lazypower
Copy link
Contributor

just as an educational follow up - the PR addresses scenarios where during teardown the kubernetes-master unit will enter a blocked state and require manual intervention because it's attempting to reach a destroyed ETCD service. This PR gives it a bailout path to continue its teardown routine unimpeded by a missing etcd endpoint.

@lazypower
Copy link
Contributor

looking through the build log it seems like the gce-etcd3 test is fine, it has a clean e2e bill of health.

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckbutler, ktsakalozos

Associated issue requirement bypassed by: chuckbutler

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48139, 48042, 47645, 48054, 48003)

@k8s-github-robot k8s-github-robot merged commit 89579c4 into kubernetes:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lazypower lazypower

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scaling down kubernetes-master fails because etcd connection_string is None
5 participants
@ktsakalozos @k8s-ci-robot @eparis @lazypower @k8s-github-robot