Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubectl api-versions caching #48016

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Fix kubectl api-versions caching #48016

merged 1 commit into from
Jun 24, 2017
+6 −1

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 24, 2017 •
edited by enisoc
Loading

xref kubernetes/kubectl#41 #47977

The point of the api-versions and version commands is to ask the server for its API groups or versions, so we don't want to use cached data

`kubectl api-versions` now always fetches information about enabled API groups and versions instead of using the local cache.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 24, 2017
@liggitt liggitt mentioned this pull request Jun 24, 2017
Closed
@liggitt liggitt assigned apelisse and pwittrock and unassigned smarterclayton and ghodss Jun 24, 2017
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 24, 2017
@liggitt
Copy link
Member Author

liggitt commented Jun 24, 2017

@kubernetes/sig-cli-bugs

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/bug Categorizes issue or PR as related to a bug. labels Jun 24, 2017
@liggitt liggitt force-pushed the api-versions-cache branch from df2fa4e to f744205 Compare June 24, 2017 05:07
@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pwittrock

Associated issue: 41

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@liggitt liggitt force-pushed the api-versions-cache branch from f744205 to fe8b5e9 Compare June 24, 2017 05:14
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2017
@liggitt
Copy link
Member Author

liggitt commented Jun 24, 2017

fixed typo

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47869, 48013, 48016, 48005)

@k8s-github-robot k8s-github-robot merged commit a82c9ac into kubernetes:master Jun 24, 2017
@liggitt liggitt deleted the api-versions-cache branch June 26, 2017 13:22
This was referenced Jun 26, 2017
Merged
Merged
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@eparis eparis added this to the v1.7 milestone Jun 26, 2017
@liggitt liggitt added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 26, 2017
@caesarxuchao caesarxuchao added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 26, 2017
@liggitt liggitt mentioned this pull request Jun 26, 2017
Closed
k8s-github-robot pushed a commit that referenced this pull request Jun 26, 2017
Merge pull request #48070 from liggitt/automated-cherry-pick-of-#4801…
6c53788 
…6-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #48016

Cherry pick of #48016 on release-1.6.

#48016: Fix kubectl api-versions caching
dchen1107 added a commit that referenced this pull request Jun 27, 2017
@dchen1107
Merge pull request #48067 from liggitt/automated-cherry-pick-of-#4801…
ccfea8f 
…6-upstream-release-1.7

Automated cherry pick of #48016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@apelisse apelisse

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
10 participants
@liggitt @pwittrock @k8s-github-robot @k8s-cherrypick-bot @smarterclayton @apelisse @caesarxuchao @ghodss @eparis @k8s-ci-robot