Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh cluster-proportional-autoscaler, etcd-empty-dir-cleanup, fluentd-gcp, and kube-addon-manager addons #48011

Merged
merged 4 commits into from
Jul 5, 2017
Merged

Refresh cluster-proportional-autoscaler, etcd-empty-dir-cleanup, fluentd-gcp, and kube-addon-manager addons #48011

merged 4 commits into from
Jul 5, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jun 24, 2017

What this PR does / why we need it: refreshes a number of addons with new base images:

  • gcr.io/google-containers/cluster-proportional-autoscaler-amd64:1.1.0-r3 (rebuilt at 1.1.0)
  • gcr.io/google-containers/etcd-empty-dir-cleanup:0.0.3
  • gcr.io/google-containers/fluentd-gcp:1.28.4
  • gcr.io/google-containers/kube-addon-manager:v6.1.2, including kubectl v1.5.7

These include upstream fixes to base images with fixes for the following CVEs:

Special notes for your reviewer:

Release note:

Update cluster-proportional-autoscaler, etcd-empty-dir-cleanup, fluentd-gcp, and kube-addon-manager addons with refreshed base images containing fixes for CVE-2015-8271, CVE-2016-7543, CVE-2016-9841, CVE-2016-9843, CVE-2017-1000366, CVE-2017-2616, and CVE-2017-7507.

cc @timstclair @MrHohn @mbohlool @crassirostris

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 24, 2017
@ixdy ixdy added this to the v1.5 milestone Jun 24, 2017
@eparis
Copy link
Contributor

eparis commented Jun 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2017
@eparis
Copy link
Contributor

eparis commented Jun 24, 2017

W0623 18:51:59.729] Error: Status 405 trying to pull repository k8s-testimages/kubekins-test: "v1 Registry API is disabled. See https://cloud.google.com/container-registry/docs/support/deprecation-notices"

Not sure if that was a flake.
/retest

@ixdy
Copy link
Member Author

ixdy commented Jun 26, 2017

Yeah, that was probably a fluke. When docker fails to download the image with the v2 api, it'll fallback to the v1 api, triggering that error message on gcr.io.

@ixdy
Copy link
Member Author

ixdy commented Jun 27, 2017

can I
/approve no-issue
my own PR?

@eparis
Copy link
Contributor

eparis commented Jun 27, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, ixdy

Associated issue requirement bypassed by: eparis

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2017
@eparis
Copy link
Contributor

eparis commented Jun 27, 2017

apparently you can not. It explains another PR where @deads2k was unable to do that same.

@eparis eparis mentioned this pull request Jun 27, 2017
Closed
@ixdy
Copy link
Member Author

ixdy commented Jun 27, 2017

/assign @saad-ali @mwielgus

@mwielgus mwielgus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 5, 2017
@ixdy
Copy link
Member Author

ixdy commented Jul 5, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 94aa962 into kubernetes:release-1.5 Jul 5, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@ixdy ixdy deleted the update-1.5-images branch May 15, 2018 23:36
This was referenced Sep 11, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

@eparis eparis

@saad-ali saad-ali

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
8 participants
@ixdy @eparis @k8s-github-robot @k8s-cherrypick-bot @mikedanese @saad-ali @mwielgus @k8s-ci-robot