Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #46500 #47994

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Automated cherry pick of #46500 #47994

merged 1 commit into from
Jun 26, 2017

Conversation

caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented Jun 23, 2017 •
edited
Loading

Cherry pick of #46500 on release-1.6.

#46500: Fix standardFinalizers - add missing

Fix #47960

@caesarxuchao caesarxuchao mentioned this pull request Jun 23, 2017
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2017
@caesarxuchao
Copy link
Member Author

@enisoc could you approve the cherry-pick?

@caesarxuchao caesarxuchao mentioned this pull request Jun 23, 2017
Closed
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2017
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@caesarxuchao
Copy link
Member Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 23, 2017
@caesarxuchao caesarxuchao removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 23, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 23, 2017
@caesarxuchao caesarxuchao assigned enisoc and unassigned zmerlynn and bprashanth Jun 24, 2017
@enisoc enisoc added this to the v1.6 milestone Jun 26, 2017
@enisoc enisoc added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 26, 2017
@enisoc
Copy link
Member

enisoc commented Jun 26, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caesarxuchao, enisoc
We suggest the following additional approver: lavalamp

Assign the PR to them by writing /assign @lavalamp in a comment when ready.

Associated issue: 46500

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 020412e into kubernetes:release-1.6 Jun 26, 2017
@rk295
Copy link

rk295 commented Jul 3, 2017

Hi, will this MR make it into 1.6.7, if so is there an ETA for that release?

@enisoc
Copy link
Member

enisoc commented Jul 5, 2017

@rk295 Yes, this fix made it into v1.6.7. I am building the release now, and if all goes well it will go out later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@enisoc enisoc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
8 participants
@caesarxuchao @k8s-github-robot @enisoc @rk295 @zmerlynn @bprashanth @k8s-ci-robot @tnozicka