Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Heapster to v1.4.0-beta.0 #47961

Merged
merged 2 commits into from
Jun 26, 2017
Merged

Conversation

piosz
Copy link
Member

@piosz piosz commented Jun 23, 2017

Heapster release candidate for Kubernetes 1.7

cc @dchen1107 @caesarxuchao

@piosz piosz added this to the v1.7 milestone Jun 23, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jun 23, 2017
@piosz piosz added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 23, 2017
@dchen1107 dchen1107 added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 23, 2017
@dchen1107
Copy link
Member

@piosz Can we have the release note for this heapster upgrade? Any new features or bug fixes for this upgrade?

@caesarxuchao
Copy link
Member

/test pull-kubernetes-e2e-gce-etcd3

@caesarxuchao
Copy link
Member

/cherrypick-approved

@caesarxuchao caesarxuchao added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 23, 2017
@piosz
Copy link
Member Author

piosz commented Jun 23, 2017

@dchen1107 I'll update with Heapster 1.4.0. This is a release candidate.

@piosz
Copy link
Member Author

piosz commented Jun 23, 2017

@caesarxuchao it's not a flake but some real problem with influxdb

I'll investigate this.

@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2017
@piosz
Copy link
Member Author

piosz commented Jun 23, 2017

The problem is with missing labels we removed in this Heapster release (kubernetes-retired/heapster#1654). I made a fix.

@DirectXMan12
Copy link
Contributor

LGTM once it passes tests

@DirectXMan12
Copy link
Contributor

I'm honestly a little surprised that we run Influx queries in the Kubernetes e2e tests. Testing that data gets correctly to a Heapster sink should be the job of the Heapster e2es. Nothing in Kubernetes should be talking directly to Influx (yes, I know that InitialResources talks directly to Influx. If that's not already deprecated, it should be).

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Jun 23, 2017

/approve

@DirectXMan12
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2017
@DirectXMan12
Copy link
Contributor

ping @marun can you approve?

@dchen1107
Copy link
Member

/approve based on other's review.

@piosz
Copy link
Member Author

piosz commented Jun 24, 2017

/approve no-issue

1 similar comment
@gmarek
Copy link
Contributor

gmarek commented Jun 26, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, dchen1107, gmarek, mwielgus, piosz

Associated issue requirement bypassed by: gmarek

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47961, 46276)

@k8s-github-robot k8s-github-robot merged commit e725c8f into kubernetes:master Jun 26, 2017
@piosz piosz deleted the heapster-1.4 branch June 26, 2017 09:12
k8s-github-robot pushed a commit that referenced this pull request Jun 27, 2017
…#47986-#47152-#47860-#47945-#47961-#47986-#47993-#48012-#48085-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085

Cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085 on release-1.7.

#47986: Change service port to avoid collision
#47152: Kubelet doesn't override addrs from Cloud provider
#47860: Make fluentd log to stdio instead of a dedicated file
#47945: add level for print flags
#47961: Bumped Heapster to v1.4.0-beta.0
#47986: Change service port to avoid collision
#47993: Use a different env var to enable the ip-masq-agent addon. We
#48012: Extending timeout waiting for delete node to become ready
#48085: Move iptables logging in kubeproxy from Errorf to V(2).Infof
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

k8s-github-robot pushed a commit that referenced this pull request Jun 28, 2017
Automatic merge from submit-queue (batch tested with PRs 48004, 48205, 48130, 48207)

Bumped Heapster to v1.4.0

``` release-note
Bumped Heapster to v1.4.0.
More details about the release https://github.com/kubernetes/heapster/releases/tag/v1.4.0
```

follow up #47961
The release candidate `v1.4.0-beta.0` turned out to be stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants