-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped Heapster to v1.4.0-beta.0 #47961
Conversation
@piosz Can we have the release note for this heapster upgrade? Any new features or bug fixes for this upgrade? |
/test pull-kubernetes-e2e-gce-etcd3 |
/cherrypick-approved |
@dchen1107 I'll update with Heapster 1.4.0. This is a release candidate. |
@caesarxuchao it's not a flake but some real problem with influxdb I'll investigate this. |
/lgtm |
The problem is with missing labels we removed in this Heapster release (kubernetes-retired/heapster#1654). I made a fix. |
LGTM once it passes tests |
I'm honestly a little surprised that we run Influx queries in the Kubernetes e2e tests. Testing that data gets correctly to a Heapster sink should be the job of the Heapster e2es. Nothing in Kubernetes should be talking directly to Influx (yes, I know that InitialResources talks directly to Influx. If that's not already deprecated, it should be). |
/approve |
/lgtm |
ping @marun can you approve? |
/approve based on other's review. |
/approve no-issue |
1 similar comment
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, dchen1107, gmarek, mwielgus, piosz Associated issue requirement bypassed by: gmarek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 47961, 46276) |
…#47986-#47152-#47860-#47945-#47961-#47986-#47993-#48012-#48085-upstream-release-1.7 Automatic merge from submit-queue Automated cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085 Cherry pick of #47986 #47152 #47860 #47945 #47961 #47986 #47993 #48012 #48085 on release-1.7. #47986: Change service port to avoid collision #47152: Kubelet doesn't override addrs from Cloud provider #47860: Make fluentd log to stdio instead of a dedicated file #47945: add level for print flags #47961: Bumped Heapster to v1.4.0-beta.0 #47986: Change service port to avoid collision #47993: Use a different env var to enable the ip-masq-agent addon. We #48012: Extending timeout waiting for delete node to become ready #48085: Move iptables logging in kubeproxy from Errorf to V(2).Infof
Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Automatic merge from submit-queue (batch tested with PRs 48004, 48205, 48130, 48207) Bumped Heapster to v1.4.0 ``` release-note Bumped Heapster to v1.4.0. More details about the release https://github.com/kubernetes/heapster/releases/tag/v1.4.0 ``` follow up #47961 The release candidate `v1.4.0-beta.0` turned out to be stable.
Heapster release candidate for Kubernetes 1.7
cc @dchen1107 @caesarxuchao