Fix commands order & add guide in k8s-ubuntu-cluster readme #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resouer
changed the title
| read -p "IP address of this machine > " myIP | ||
| echo | ||
| echo |
There was a problem hiding this comment.
Bunch of extra spaces here and below.
|
@rjnagal removed extra spaces |
|
LGTM |
rjnagal
added a commit
that referenced
this pull request
Feb 25, 2015
Fix commands order & add guide in k8s-ubuntu-cluster readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous PR (#3922) messed up the commands order and I'd like to sort them rightly here.
BTW, I & my colleague are willing to maintain this part in the future (including continually test it on latest k8s and upgrade it to fully automatic), so I add a line in the readme to make it work.