Remove pkg/util/merge and replace with evanphx/json-patch #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghodss may be interested. |
|
👍 |
|
cc @bgrant0607 |
bgrant0607
added
the
lgtm
|
LGTM |
bgrant0607
added a commit
that referenced
this pull request
Feb 25, 2015
Remove pkg/util/merge and replace with evanphx/json-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add RFC6902 and RFC7386 JSON Patch capabilities as well as helpers. evanphx/json-patch provides utilities to create and apply patches and better test coverage compared with the single method in pkg/util/merge. JSON Patch is currently used by kubectl --patch and --override and this is a drop in replacement. It will soon be used by apiserver PATCH verb #4578 and config reconciliation #1702.