Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify version the logging documentation applies to #4719

Conversation

browning
Copy link
Contributor

I was a confused for a bit, because the logging documentation in release 0.10 says that kube-up script will tell you the URL of your kibana service. However, that feature in cluster/gce/util.sh is not present until the 0.11 release.

@zmerlynn
Copy link
Member

Actually, that's just a bug in 0.10 (and sadly 0.9.1, but not 0.9.0).
On Feb 22, 2015 10:38 PM, "Brian Browning" notifications@github.com wrote:

I was a confused for a bit, because the logging documentation in release
0.10 says that kube-up script will tell you the URL of your kibana service.
However, that feature in cluster/gce/util.sh is not present until the 0.11

release.

You can view, comment on, or merge this pull request online at:

#4719
Commit Summary

  • Add a clarification that the console output showing the kibana url
    is not present in versions below 0.11

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#4719.

@rjnagal
Copy link
Contributor

rjnagal commented Feb 23, 2015

@zmerlynn Is it safe to just say 0.11 as this PR does, rather than adding qualifiers for the two releases?

@zmerlynn
Copy link
Member

It's safe, but it was also true in earlier releases, too. I guess I'm just being unnecessarily pedantic.

@rjnagal
Copy link
Contributor

rjnagal commented Feb 23, 2015

ok, I am going to merge this as is, to keep it less confusing :)

rjnagal added a commit that referenced this pull request Feb 23, 2015
…clarification

Clarify version the logging documentation applies to
@rjnagal rjnagal merged commit 8c2e81e into kubernetes:master Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants