-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoreOS updates to v0.11.0 and kubelet args fix #4708
Conversation
Replaced kubelet argument --etcd_servers with --api_servers. Fixes kubernetes#4614
b10bdbe
to
150968f
Compare
150968f
to
13c32d9
Compare
" ExecStartPre=/usr/bin/chmod +x /opt/bin/kubelet\n", | ||
" ExecStart=/opt/bin/kubelet \\\n", | ||
" --address=0.0.0.0 \\\n", | ||
" --port=10250 \\\n", | ||
" --hostname_override=${DEFAULT_IPV4} \\\n", | ||
" --etcd_servers=http://", {"Fn::GetAtt" :["KubernetesMasterInstance" , "PrivateIp"]}, ":4001\\\n", | ||
" --api_servers=", {"Fn::GetAtt" :["KubernetesMasterInstance" , "PrivateIp"]}, ":8080\\\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be port 7080.
Port 8080 has no authentication.
Port 8080 should not be reachable from minions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm willing to merge this, but I want to understand why this is working.
On GCE, apiserver only listed on localhost:8080, last I checked.
I'm not sure why this is working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On GCE, apiserver only listed on localhost:8080, last I checked.
So it makes sense to configure kubelet
to reach 8080, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think a kubelet on node x can reach apiserver which is serving on localhost:8080 of node y.
@erictune it surely works this way. |
Oh. This is working because this sets |
CoreOS updates to v0.11.0 and kubelet args fix
@erictune I understand things are not perfect with current CoreOS set-up, but it does work and is up-to-date sooner than other community-maintained Kubernetes guides. I am open to suggestions and test PRs from others, ofc. |
@pires Your work on on CoreOS is much appreciated. My comment about this is a mess was directed at myself and the mess I created when I introduced multiple ways to do master-to-node communication/auth. |
@erictune thank you for your kind words. But please, do share your ideas and let's improve this. |
Upgraded Kubernetes to 0.11.0.
Replaced kubelet argument --etcd_servers with --api_servers.
Fixes #4614