Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreOS updates to v0.11.0 and kubelet args fix #4708

Merged
merged 3 commits into from
Mar 2, 2015

Conversation

pires
Copy link
Contributor

@pires pires commented Feb 22, 2015

Upgraded Kubernetes to 0.11.0.
Replaced kubelet argument --etcd_servers with --api_servers.
Fixes #4614

Replaced kubelet argument --etcd_servers with --api_servers.
Fixes kubernetes#4614
@pires pires force-pushed the update_coreos_kubelet branch 2 times, most recently from b10bdbe to 150968f Compare February 22, 2015 16:16
@pires pires force-pushed the update_coreos_kubelet branch from 150968f to 13c32d9 Compare February 22, 2015 16:18
@erictune erictune self-assigned this Feb 24, 2015
" ExecStartPre=/usr/bin/chmod +x /opt/bin/kubelet\n",
" ExecStart=/opt/bin/kubelet \\\n",
" --address=0.0.0.0 \\\n",
" --port=10250 \\\n",
" --hostname_override=${DEFAULT_IPV4} \\\n",
" --etcd_servers=http://", {"Fn::GetAtt" :["KubernetesMasterInstance" , "PrivateIp"]}, ":4001\\\n",
" --api_servers=", {"Fn::GetAtt" :["KubernetesMasterInstance" , "PrivateIp"]}, ":8080\\\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be port 7080.
Port 8080 has no authentication.
Port 8080 should not be reachable from minions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm willing to merge this, but I want to understand why this is working.
On GCE, apiserver only listed on localhost:8080, last I checked.
I'm not sure why this is working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On GCE, apiserver only listed on localhost:8080, last I checked.

So it makes sense to configure kubelet to reach 8080, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a kubelet on node x can reach apiserver which is serving on localhost:8080 of node y.

@pires
Copy link
Contributor Author

pires commented Feb 27, 2015

@erictune it surely works this way.

@erictune
Copy link
Member

erictune commented Mar 2, 2015

Oh. This is working because this sets --address=0.0.0.0.
Other distros are setting --address=127.0.0.1.
This is a mess, but now I understand why this works and it fixes stuff so I'll merge it.
Thanks for the fix.

erictune added a commit that referenced this pull request Mar 2, 2015
CoreOS updates to v0.11.0 and kubelet args fix
@erictune erictune merged commit 4ef76ab into kubernetes:master Mar 2, 2015
@pires
Copy link
Contributor Author

pires commented Mar 2, 2015

@erictune I understand things are not perfect with current CoreOS set-up, but it does work and is up-to-date sooner than other community-maintained Kubernetes guides. I am open to suggestions and test PRs from others, ofc.

@erictune
Copy link
Member

erictune commented Mar 9, 2015

@pires Your work on on CoreOS is much appreciated. My comment about this is a mess was directed at myself and the mess I created when I introduced multiple ways to do master-to-node communication/auth.

@pires
Copy link
Contributor Author

pires commented Mar 9, 2015

@erictune thank you for your kind words. But please, do share your ideas and let's improve this.

@pires pires deleted the update_coreos_kubelet branch September 5, 2016 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod containers with no environment variables set
3 participants