Wrap HumanReadablePrinter in tab output unless explicitly asked not to #47013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
smarterclayton
added
area/usability
sig/api-machinery
|
Regression caused by #40848 (waiting for issue to be opened). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton Associated issue: 40848 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
approved
Fixes an accidental regression. In general, we should not accept an incoming tabwriter and instead manage at a higher level. Fix the bug and add a comment re: future refactoring.
smarterclayton
force-pushed
the
fix_printer
branch
from
e654825 to
b1abedb
Compare
|
/retest |
|
Fixes #47093 |
smarterclayton
added
the
lgtm
k8s-github-robot
added
the
do-not-merge
|
Applying label from review, not sure why it didn't get added. |
smarterclayton
added
release-note-none
|
Automatic merge from submit-queue (batch tested with PRs 47024, 47050, 47086, 47081, 47013) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl getwas not properly aligning its output due to #40848Fixes an accidental regression. In general, we should not accept an incoming tabwriter and instead manage at a higher level. Fix the bug and add a comment re: future refactoring.