Add GOMAXPROCS in a few more places #4675
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
...and doc generation is not broken, just my GOPATH. This should be good to go. |
|
Thanks for the double-check :) will merge on green. |
vmarmol
added a commit
that referenced
this pull request
Feb 20, 2015
Add GOMAXPROCS in a few more places
|
So this is to prevent people from being able to set GOMAXPROCS? |
|
No, this is so that if someone parallelizes something, it'll actually have an effect. We could also use a command line parameter to set the number of os threads we use, but this should be OK for the moment. Nothing stops people from setting it to a higher value later, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4240.
...Something not in this PR broke doc generation...