Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for multiple resources to kubectl #4667

Merged
merged 1 commit into from
Feb 23, 2015

Conversation

kbeecher
Copy link
Contributor

You can specify multiple resources by name when using the delete, get
and stop commands.

Resolves #3050

You can specify multiple resources by name when using the delete, get
and stop commands.
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@kbeecher
Copy link
Contributor Author

I had already set up and signed a CLA using my endocode.com address. However, the email address on my GitHub account was not an endocode.com one.

I have updated my account so that the primary email is the same which I used to sign the CLA.

@vmarmol
Copy link
Contributor

vmarmol commented Feb 20, 2015

Assigning to @brendanburns

@kbeecher I can't seem to find your CLA :( I see an info@ address, is that yours?

Do you see it in: https://cla.developers.google.com/clas

@bgrant0607
Copy link
Member

cc @smarterclayton

@smarterclayton
Copy link
Contributor

LGTM - thanks for adding tests

@bgrant0607
Copy link
Member

@kbeecher Did you intend for that to be a corporate CLA? It was registered as a user CLA.

@kbeecher
Copy link
Contributor Author

@vmarmol @bgrant0607 The CLA was definitely a corporate one, I have it in my inbox now. I entered the info@ address because the CLA needed a Google Group for our contributors.

@googlebot
Copy link

CLAs look good, thanks!

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2015
@bgrant0607
Copy link
Member

Thanks a lot.

rjnagal added a commit that referenced this pull request Feb 23, 2015
Adds support for multiple resources to kubectl
@rjnagal rjnagal merged commit 28dd73d into kubernetes:master Feb 23, 2015
@kbeecher kbeecher deleted the kbeecher/multi-resource branch April 29, 2015 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl commands should support multiple resources
7 participants