Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ContainerRuntimeVersion to kubectl get nodes -o=wide output #46646

Merged
merged 1 commit into from
Jun 23, 2017
Merged

add ContainerRuntimeVersion to kubectl get nodes -o=wide output #46646

merged 1 commit into from
Jun 23, 2017

Conversation

evie404
Copy link
Contributor

@evie404 evie404 commented May 30, 2017

What this PR does / why we need it: adds container runtime version to kubectl get nodes -o=wide output as a way to surface more node-level information

When upgrading to a new container runtime version (docker 1.11 -> docker 1.12) or when experimenting with a different container runtime version (experimenting with rkt in a docker cluster), it's useful for cluster operators to see which nodes are running which container runtime version. kubectl get nodes -o=wide already provides kernel and OS version, and I believe adding container runtime version would be good.

Release note:

container runtime version has been added to the output of `kubectl get nodes -o=wide` as `CONTAINER-RUNTIME`

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @rickypai. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 30, 2017
@eparis
Copy link
Contributor

eparis commented May 30, 2017

@k8s-bot ok to test
@fabiand do we have any thoughts on how wide is too -o wide?

I like it, more than I care about the kernel I usually care about the runtime...

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2017
@evie404
Copy link
Contributor Author

evie404 commented May 30, 2017 •
edited
Loading

let me give a sample output:

NAME                             STATUS                     AGE       VERSION   EXTERNAL-IP      OS-IMAGE             KERNEL-VERSION       CONTAINER-RUNTIME
ip-10-22-168-211.ec2.internal    Ready                      73d       v1.6.4    24.111.11.60     Ubuntu 14.04.5 LTS   4.4.0-38-generic     docker://1.11.2
ip-10-22-192-121.ec2.internal    Ready                      73d       v1.6.4    34.211.73.26     Ubuntu 14.04.5 LTS   4.4.0-38-generic     docker://1.11.2
ip-10-22-218-12.ec2.internal     Ready                      73d       v1.6.4    56.205.162.20    Ubuntu 14.04.5 LTS   4.4.0-38-generic     docker://1.11.2
ip-10-122-222-121.ec2.internal   Ready                      73d       v1.6.4    84.173.159.122   Ubuntu 14.04.5 LTS   4.4.0-38-generic     docker://1.11.2

in my case, this change makes the line length 156 characters for the title, and 154 characters for the information.
vs. currently: 132 characters for the title, and 134 characters for the node information.

@evie404
Copy link
Contributor Author

evie404 commented May 30, 2017

@k8s-bot pull-kubernetes-unit test this

@fabiand
Copy link
Contributor

fabiand commented May 31, 2017

I guess the question was for @fabianofranz

@evie404 evie404 force-pushed the rpai/add_container_runtime_version_to_node_wide_printer branch from 1d5fe73 to 8c0c762 Compare June 1, 2017 23:52
@evie404
Copy link
Contributor Author

evie404 commented Jun 2, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@fejta
Copy link
Contributor

fejta commented Jun 2, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this
ref: #46827

@evie404
Copy link
Contributor Author

evie404 commented Jun 7, 2017

if I can get some eyes on this that'd be great. @kubernetes/sig-cli-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jun 7, 2017
@k8s-ci-robot
Copy link
Contributor

@rickypai: Reiterating the mentions to trigger a notification:
@kubernetes/sig-cli-pr-reviews.

In response to this:

if I can get some eyes on this that'd be great. @kubernetes/sig-cli-pr-reviews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabianofranz
Copy link
Contributor

Thanks @rickypai!
There isn't a specifically set restriction on -o wide, if you request it you know it can potentially break line.
/lgtm
/approve no-issue
/kind enhancement

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/enhancement labels Jun 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, rickypai

Associated issue requirement bypassed by: fabianofranz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2017
@evie404
Copy link
Contributor Author

evie404 commented Jun 20, 2017

can this be added to 1.7 milestone or wait for 1.8?

@evie404
Copy link
Contributor Author

evie404 commented Jun 20, 2017

/test pull-kubernetes-federation-e2e-gce

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47403, 46646, 46906, 46527, 46792)

@k8s-github-robot k8s-github-robot merged commit 4a1d95e into kubernetes:master Jun 23, 2017
@evie404 evie404 deleted the rpai/add_container_runtime_version_to_node_wide_printer branch June 23, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabianofranz fabianofranz

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@evie404 @k8s-ci-robot @eparis @fabiand @fejta @fabianofranz @k8s-github-robot