Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default NODE_OS to gci on GCE installs #46512

Merged
merged 1 commit into from
Aug 19, 2017
Merged

Default NODE_OS to gci on GCE installs #46512

merged 1 commit into from
Aug 19, 2017

Conversation

thockin
Copy link
Member

@thockin thockin commented May 26, 2017

Looking at https://github.com/kubernetes/test-infra/tree/master/jobs,
any job with "cvm" in the name explicitly sets this variable, so I hope
it is only the default.

Release note:

Change GCE installs (kube-up.sh) to use GCI/COS for node OS, by default.

@mtaufen @dchen1107 @ixdy

@thockin
Default NODE_OS to gci on GCE installs
0c909cb 
Looking at https://github.com/kubernetes/test-infra/tree/master/jobs,
any job with "cvm" in the name explicitly sets this variable, so I hope
it is only the default.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 26, 2017
@thockin
Copy link
Member Author

thockin commented May 26, 2017

@k8s-bot pull-kubernetes-node-e2e test this

@mtaufen
Copy link
Contributor

mtaufen commented May 26, 2017

The e2es rely on the setting in config-test.sh, IIRC.

@mtaufen
Copy link
Contributor

mtaufen commented May 26, 2017

@k8s-bot pull-kubernetes-unit test this

@thockin
Copy link
Member Author

thockin commented May 30, 2017

all green

@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2017
@mtaufen
Copy link
Contributor

mtaufen commented Jun 12, 2017

/lgtm

I'm assuming we aren't changing cluster/gce/config-test.sh because tests for debian will just assume they have the default test config, and tests for gci will manually set gci. If that's wrong please update config-test.sh as well.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2017
@mtaufen
Copy link
Contributor

mtaufen commented Jun 12, 2017

/approve no-issue

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 96 hours old. Re-running tests.

@ixdy
Copy link
Member

ixdy commented Jun 15, 2017

/retest

@ixdy
Copy link
Member

ixdy commented Jun 15, 2017

did we intend for this to get into 1.7?

@cblecker
Copy link
Member

/retest

@thockin
Copy link
Member Author

thockin commented Aug 18, 2017

/approve

@thockin
Copy link
Member Author

thockin commented Aug 18, 2017

/lgtm
/approve no issue

@k8s-ci-robot
Copy link
Contributor

@thockin: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve no issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thockin
Copy link
Member Author

thockin commented Aug 19, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtaufen, thockin

Associated issue requirement bypassed by: thockin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2017
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46512, 50146)

@k8s-github-robot k8s-github-robot merged commit 43c6c13 into kubernetes:master Aug 19, 2017
@thockin thockin deleted the gce-default-to-gci branch August 14, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mtaufen mtaufen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thockin @mtaufen @k8s-github-robot @ixdy @cblecker @k8s-ci-robot @fejta-bot