Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] Bump golang versions to 1.7.6 #46408

Merged
merged 1 commit into from
May 27, 2017
Merged

[release-1.5] Bump golang versions to 1.7.6 #46408

merged 1 commit into from
May 27, 2017

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented May 25, 2017 •
edited
Loading

What this PR does / why we need it:
Addresses #46391 for the release-1.5 branch.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Tests will not pass until kube-cross image is built and pushed to GCR.

Release note:

Upgrade golang version to 1.7.6

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 25, 2017
@cblecker cblecker mentioned this pull request May 25, 2017
Closed
@timstclair timstclair added this to the v1.5 milestone May 25, 2017
@ixdy
Copy link
Member

ixdy commented May 25, 2017

/lgtm
I'll build the crossbuild image and post here again when done.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2017
@ixdy
Copy link
Member

ixdy commented May 25, 2017

gcr.io/google_containers/kube-cross:v1.7.6-k8s1.5-0 pushed.

@k8s-bot test this

@cblecker
Copy link
Member Author

Thanks @ixdy
@k8s-bot pull-kubernetes-cross test this

luxas
luxas approved these changes May 25, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@luxas
Copy link
Member

luxas commented May 25, 2017

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy, luxas

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@cblecker
Copy link
Member Author

/assign @mwielgus
/unassign @jbeda @lavalamp

@k8s-ci-robot k8s-ci-robot assigned mwielgus and unassigned jbeda and lavalamp May 25, 2017
@mwielgus mwielgus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 26, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b067d87 into kubernetes:release-1.5 May 27, 2017
@cblecker cblecker deleted the go-1.7.6-release-1.5 branch May 27, 2017 01:27
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

Assignees

@luxas luxas

@ixdy ixdy

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
10 participants
@cblecker @ixdy @luxas @k8s-github-robot @k8s-cherrypick-bot @jbeda @lavalamp @timstclair @mwielgus @k8s-ci-robot