Redirect all files in /examples folder to kubernetes/examples repo #46362

sebgoa · 2017-05-24T16:59:28Z

What this PR does / why we need it:

Examples are being moved to their own repository: https://github.com/kubernetes/examples

We need to remove them from the main repo , but first we need to keep a redirect.

This is a big organizational change, but nothing technical (aside from e2e tests)

Which issue this PR fixes

fixes part of #24343

Special notes for your reviewer:

WIP, I still need to figure out what to do with the BUILD script and tests, plus take care of the e2e tests that use some of these examples.

release notes

Redirect all examples README to the the kubernetes/examples repo

sebgoa · 2017-05-24T17:01:22Z

cc/ @kubernetes/examples big change coming here

ahmetb · 2017-05-24T17:23:38Z

Sent kubernetes/examples#5, maybe we can merge that one first and then update the paths that are not in staging/ in a single PR.

ahmetb · 2017-05-24T17:42:54Z

Have we ever moved out Go code and/or YAML files? Replacing all files with the same test is causing Go builds to break (also would break any tutorials referencing to their YAML files or kubectl create -f https://....

What if we did this: If there's a README.md in the directory, replace it with the migration notice. If there's no README.md in a directory, add a README.md with the migration notice, leave all other files untouched?

sebgoa · 2017-05-24T18:27:38Z

yes, I wanted to get this out to get some feedback and see what all it would break.

thockin · 2017-05-25T05:05:40Z

examples/meteor/README.md

-<!-- BEGIN MUNGE: GENERATED_ANALYTICS -->
-[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/examples/meteor/README.md?pixel)]()
-<!-- END MUNGE: GENERATED_ANALYTICS -->
+This file has moved to [https://github.com/kubernetes/examples/blob/master/staging/teor/README.md](https://github.com/kubernetes/examples/blob/master/staging/teor/README.md)


Some of these links are broken - I just picked this one at random.

sebgoa · 2017-06-13T12:01:28Z

@ahmetb ok I rebased this and just added a notice in the README.

I think it is a good step to start directing folks to the other repo. Once this gets merged we can clean up further.

ahmetb · 2017-06-13T20:21:58Z

/lgtm

I like how you only modified only the README.md files. Otherwise it would break many docs/tutorials in k8s.io and other places. Perhaps delete the guidelines.md as well?

Also what do you think of using git.k8s.io/examples format instead of github URLs? I think this feature is rather new.

sebgoa · 2017-06-14T13:34:39Z

/assign @thockin

k8s-github-robot · 2017-06-27T21:32:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahmetb, sebgoa
We suggest the following additional approver: brendandburns

Assign the PR to them by writing /assign @brendandburns in a comment when ready.

Associated issue: 24343

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

examples/OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-06-27T21:38:32Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahmetb, sebgoa
We suggest the following additional approver: brendandburns

Assign the PR to them by writing /assign @brendandburns in a comment when ready.

Associated issue: 24343

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

examples/OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

sebgoa · 2017-06-29T18:36:12Z

/retest

0xmichalis · 2017-06-29T19:08:29Z

fyi @kubernetes/sig-testing-misc since this was a discussion topic in the last call

grodrigues3 · 2017-06-29T22:31:30Z

@brendanburns PTAL.

sebgoa · 2017-07-03T13:56:35Z

@thockin Hi Tim, sorry to ping you directly, but I am out of ideas on how to get attention to this.

thanks

timothysc · 2017-07-14T02:18:55Z

examples/elasticsearch/README.md

-<!-- BEGIN MUNGE: GENERATED_ANALYTICS -->
-[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/examples/elasticsearch/README.md?pixel)]()
-<!-- END MUNGE: GENERATED_ANALYTICS -->
+This file has moved to [https://github.com/kubernetes/examples/blob/master/staging/elasticsearch/README.md](https://github.com/kubernetes/examples/blob/master/staging/elasticsearch/README.md)


I don't understand why there isn't just a single readme at the root, everything else seems redundant.

@timothysc we went with the same concept than when the docs/devel were moved. We leave breadcrumbs in case people linked directly to the repo. that way they know where to go:

https://github.com/kubernetes/kubernetes/blob/master/docs/devel/api-conventions.md

Well I'm ok with it for now just to get it out of the repo.

good I have been trying to get this merged sine May 24.

timothysc · 2017-07-14T15:02:36Z

@sebgoa could you resolve the conflicts and I will green light this 2day.

I want these things out ASAP.

sebgoa · 2017-07-14T15:26:25Z

rebased

k8s-github-robot · 2017-07-14T16:03:25Z

Automatic merge from submit-queue

Automatic merge from submit-queue Redirect all files in /examples folder to kubernetes/examples repo **What this PR does / why we need it**: Examples are being moved to their own repository: https://github.com/kubernetes/examples We need to remove them from the main repo , but first we need to keep a redirect. This is a *big* organizational change, but nothing technical (aside from e2e tests) **Which issue this PR fixes** fixes part of kubernetes#24343 **Special notes for your reviewer**: WIP, I still need to figure out what to do with the BUILD script and tests, plus take care of the e2e tests that use some of these examples. **release notes** ```release-note Redirect all examples README to the the kubernetes/examples repo ```

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2017

sebgoa changed the title ~~Redirect all files in /examples folder to kubernetes/examples repo~~ [WIP] Redirect all files in /examples folder to kubernetes/examples repo May 24, 2017

k8s-github-robot assigned brendandburns and thockin May 24, 2017

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels May 24, 2017

thockin reviewed May 25, 2017

View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2017

This was referenced Jun 11, 2017

missing create for kubectl #47287

Closed

Hazelcast E2E test is flaky #14897

Closed

sebgoa force-pushed the examplesmove branch from de5a27b to 8959b61 Compare June 13, 2017 11:59

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2017

sebgoa force-pushed the examplesmove branch from 8959b61 to 5f5989a Compare June 13, 2017 12:50

k8s-github-robot added the retest-not-required-docs-only label Jun 13, 2017

k8s-ci-robot assigned ahmetb Jun 13, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2017

k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 13, 2017

k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jun 14, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2017

sebgoa changed the title ~~[WIP] Redirect all files in /examples folder to kubernetes/examples repo~~ Redirect all files in /examples folder to kubernetes/examples repo Jun 27, 2017

sebgoa force-pushed the examplesmove branch from 5f5989a to e19a959 Compare June 27, 2017 20:25

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2017

k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 29, 2017

0xmichalis removed the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 29, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2017

sebgoa mentioned this pull request Jul 4, 2017

Removes unmaintained storm example #48441

Closed

timothysc suggested changes Jul 14, 2017

View reviewed changes

timothysc added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 14, 2017

ixdy mentioned this pull request Jul 14, 2017

Multi architecture guestbook example #48443

Closed

timothysc approved these changes Jul 14, 2017

View reviewed changes

timothysc removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jul 14, 2017

timothysc added this to the v1.8 milestone Jul 14, 2017

add redirect notice in all readme files

b0bc271

sebgoa force-pushed the examplesmove branch from e19a959 to b0bc271 Compare July 14, 2017 15:18

k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 14, 2017

timothysc self-assigned this Jul 14, 2017

timothysc added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2017

k8s-github-robot merged commit cb712e4 into kubernetes:master Jul 14, 2017

spiffxp mentioned this pull request Jul 24, 2017

Failure cluster [5be8b0...] failed 196 builds, 19 jobs, and 1 tests over 1 days #49245

Closed

mattjmcnaughton mentioned this pull request Aug 25, 2017

Examples Links on https://kubernetes.io/docs often point to old examples location kubernetes/website#5203

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redirect all files in /examples folder to kubernetes/examples repo #46362

Redirect all files in /examples folder to kubernetes/examples repo #46362

sebgoa commented May 24, 2017 •

edited

Loading

sebgoa commented May 24, 2017

ahmetb commented May 24, 2017

ahmetb commented May 24, 2017 •

edited

Loading

sebgoa commented May 24, 2017

thockin May 25, 2017

sebgoa commented Jun 13, 2017

ahmetb commented Jun 13, 2017 •

edited

Loading

sebgoa commented Jun 14, 2017

k8s-github-robot commented Jun 27, 2017

k8s-github-robot commented Jun 27, 2017

sebgoa commented Jun 29, 2017

0xmichalis commented Jun 29, 2017

grodrigues3 commented Jun 29, 2017

sebgoa commented Jul 3, 2017

timothysc Jul 14, 2017

sebgoa Jul 14, 2017

timothysc Jul 14, 2017

sebgoa Jul 14, 2017

timothysc commented Jul 14, 2017

sebgoa commented Jul 14, 2017

k8s-github-robot commented Jul 14, 2017

Redirect all files in /examples folder to kubernetes/examples repo #46362

Redirect all files in /examples folder to kubernetes/examples repo #46362

Conversation

sebgoa commented May 24, 2017 • edited Loading

sebgoa commented May 24, 2017

ahmetb commented May 24, 2017

ahmetb commented May 24, 2017 • edited Loading

sebgoa commented May 24, 2017

thockin May 25, 2017

Choose a reason for hiding this comment

sebgoa commented Jun 13, 2017

ahmetb commented Jun 13, 2017 • edited Loading

sebgoa commented Jun 14, 2017

k8s-github-robot commented Jun 27, 2017

k8s-github-robot commented Jun 27, 2017

sebgoa commented Jun 29, 2017

0xmichalis commented Jun 29, 2017

grodrigues3 commented Jun 29, 2017

sebgoa commented Jul 3, 2017

timothysc Jul 14, 2017

Choose a reason for hiding this comment

sebgoa Jul 14, 2017

Choose a reason for hiding this comment

timothysc Jul 14, 2017

Choose a reason for hiding this comment

sebgoa Jul 14, 2017

Choose a reason for hiding this comment

timothysc commented Jul 14, 2017

sebgoa commented Jul 14, 2017

k8s-github-robot commented Jul 14, 2017

sebgoa commented May 24, 2017 •

edited

Loading

ahmetb commented May 24, 2017 •

edited

Loading

ahmetb commented Jun 13, 2017 •

edited

Loading