Move the various "defer" calls before the creation in pods.go e2e test. #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,16 +124,14 @@ var _ = Describe("Pods", func() { | |||
| } | |||
|
|
|||
| By("submitting the pod to kubernetes") | |||
| // We call defer here in case there is a problem with | |||
There was a problem hiding this comment.
I'm not sure this comment is really necessary since the semantics of defer are well known to go developers.
roberthbailey
added
the
lgtm
|
LGTM. |
zmerlynn
added a commit
that referenced
this pull request
Feb 23, 2015
Move the various "defer" calls before the creation in pods.go e2e test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested as a way to help with test flakiness. Ran 25 iterations of this e2e test with no failure.