Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a subnet for reserving the service cluster IP range #46150

Merged
merged 1 commit into from
May 25, 2017
Merged

Create a subnet for reserving the service cluster IP range #46150

merged 1 commit into from
May 25, 2017

Conversation

bowei
Copy link
Member

@bowei bowei commented May 20, 2017

This will be done if IP aliases is enabled on GCP.

NONE

@bowei
Create a subnet for reserving the service cluster IP range
7c9b6e9 
This will be done if IP aliases is enabled on GCP.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels May 20, 2017
@bowei
Copy link
Member Author

bowei commented May 23, 2017

/assign @freehan

@bowei
Copy link
Member Author

bowei commented May 23, 2017

/unassign @gmarek @jszczepkowski

@bowei
Copy link
Member Author

bowei commented May 23, 2017

/assign @thockin

@freehan
Copy link
Contributor

freehan commented May 24, 2017

/lgtm

Just to confirm, this is only to reserve service-ip-cidr, right?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2017
@bowei
Copy link
Member Author

bowei commented May 24, 2017

@freehan -- yes

@bowei
Copy link
Member Author

bowei commented May 24, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@bowei
Copy link
Member Author

bowei commented May 24, 2017

@k8s-bot kops aws e2e test this

@bowei
Copy link
Member Author

bowei commented May 24, 2017

@k8s-bot gce etcd3 e2e test this

@bowei
Copy link
Member Author

bowei commented May 24, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@bowei
Copy link
Member Author

bowei commented May 24, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@thockin
Copy link
Member

thockin commented May 24, 2017

/lgtm
/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, freehan, thockin

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2017
@bowei
Copy link
Member Author

bowei commented May 24, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@bowei
Copy link
Member Author

bowei commented May 24, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 24, 2017 •
edited
Loading

@bowei: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins kops AWS e2e 7c9b6e9 link @k8s-bot kops aws e2e test this
Jenkins GCE etcd3 e2e 7c9b6e9 link @k8s-bot gce etcd3 e2e test this
pull-kubernetes-federation-e2e-gce 7c9b6e9 link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bowei
Copy link
Member Author

bowei commented May 24, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46299, 46309, 46311, 46303, 46150)

@k8s-github-robot k8s-github-robot merged commit 80171e5 into kubernetes:master May 25, 2017
@bowei bowei deleted the ip-alias-service branch September 5, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@freehan freehan

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bowei @freehan @thockin @k8s-github-robot @k8s-ci-robot @gmarek @jszczepkowski