Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using kubectl to obtain public IP for guestbook service #4606

Merged
merged 1 commit into from
Feb 26, 2015

Conversation

satnam6502
Copy link
Contributor

Related to #4577 this changes the Guestbook example documentation to use kubectl to obtain the public IP of the guestbook service rather than the gcloud command (which after #4577 will result in a forwarding rule which is no longer exactly the name of the service).

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@satnam6502
Copy link
Contributor Author

After months of happily making commits why do I now get these CLA messages?
I filled in form a few days ago. I guess that was not enough.
As a Google employee, what form should I fill in?

@yujuhong
Copy link
Contributor

From @lavalamp: It's important to use your @google.com email address in your commits (edit .git/config) to make the cla bot happy.

The git config instructions: https://help.github.com/articles/setting-your-email-in-git

@satnam6502
Copy link
Contributor Author

I've changed my email to satnam@google.com for commits from my kubernetes repo.

@satnam6502
Copy link
Contributor Author

Do I now need to fill out https://cla.developers.google.com/clas/new?kind=KIND_CORPORATE&domain=DOMAIN_GOOGLE ? If yes, then what the value values for contributor group and primary point of contact and authorized signer? Thanks.

@lavalamp
Copy link
Member

I don't think googlers need to fill that out.

@satnam6502
Copy link
Contributor Author

So what else do I need to do to stop getting these googlebot annoying messages?

@lavalamp
Copy link
Member

We won't know if your change to your @google.com email worked until you make another PR-- the email is embedded in the commit, which you made previously to changing the email-- right?

@yujuhong
Copy link
Contributor

Also, @satnam6502, I still can't find your name in the Google organization member list. Maybe it takes time to propagate/approve? Do you see a Google organization logo on your github page?

@satnam6502
Copy link
Contributor Author

@yujuhong : I think I am sorted now. But I don't know about the "Google organization member list". Where can I see that?

@yujuhong
Copy link
Contributor

@satnam6502, glad to hear that!

I saw the member list from https://github.com/orgs/google/people

@satnam6502
Copy link
Contributor Author

Oh, I am not on that member list. Neither are you :-) And I can't spot any other Googlers on that list. Should I be on it?

@satnam6502
Copy link
Contributor Author

Ping?

To play with the service itself, find the external IP of the load balancer as shown below by extracting a value for `publicIPs` (in this example `107.178.218.166`) and then visit `http://<ip>:3000`.

```shell
$ cluster/kubectl.sh get services guestbook -o json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: if you use a template as the output, you can extract just the publicIPs. Try

kubectl get services guestbook -o template --template='{{index . "publicIPs"}}'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I was wondering how to do that. I'll update this PR.

@satnam6502
Copy link
Contributor Author

Updated to use @jlowdermilk template that prints out just the public IPs and I also added a section suggesting the explicit deletion of the service which will clean up any project level resources like forwarding rules and target pools. PTAL, thank you.

@@ -189,6 +184,13 @@ For details about limiting traffic to specific sources, see the [GCE firewall do

### Step Seven: Cleanup

You should delete the service which will remove any associated resources that were created e.g. load balancers, forwarding rules and target pools.
```shell
$ cluster/kubectl.sh delete service guestbook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think you can do a delete -f on the guestbook directory to cleanup all the resources, including the service.

@j3ffml
Copy link
Contributor

j3ffml commented Feb 26, 2015

LGTM for the readme change, but you appear to have outdated gendocs output in kubectl.md. Try make clean followed by hack/run-gendocs.sh

@satnam6502
Copy link
Contributor Author

@jlowdermilk : I've fixed the docs issues, thanks, and I've changed the cleanup command to do a bulk delete as you suggest. I think it's good to apply the LGTM label (when you are ready) to make it easier for people to scan PRs that are LGTM-ed but not committed yet. Thanks.

@satnam6502 satnam6502 assigned j3ffml and unassigned erictune Feb 26, 2015
@j3ffml
Copy link
Contributor

j3ffml commented Feb 26, 2015

LGTM. shippable failure is flake. merging.

j3ffml added a commit that referenced this pull request Feb 26, 2015
Using kubectl to obtain public IP for guestbook service
@j3ffml j3ffml merged commit d085cd2 into kubernetes:master Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants