Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.6.3] Cherrypick eviction fix from release-1.6 #46049

Merged
merged 1 commit into from
May 19, 2017
Merged

[release-1.6.3] Cherrypick eviction fix from release-1.6 #46049

merged 1 commit into from
May 19, 2017

Conversation

enisoc
Copy link
Member

@enisoc enisoc commented May 18, 2017

This is a cherrypick of the following PR from release-1.6:

Fix kubelet panic during disk eviction introduced in 1.6.3.

@enisoc enisoc added this to the v1.6 milestone May 18, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enisoc
We suggest the following additional approver: vishh

Assign the PR to them by writing /assign @vishh in a comment when ready.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2017
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 18, 2017
@enisoc enisoc mentioned this pull request May 18, 2017
Merged
@enisoc
Copy link
Member Author

enisoc commented May 18, 2017

@k8s-bot unit test this
@k8s-bot verify test this
@k8s-bot node e2e test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@enisoc enisoc added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/P0 and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 18, 2017
@enisoc
Copy link
Member Author

enisoc commented May 18, 2017

@k8s-bot test this

@enisoc
Copy link
Member Author

enisoc commented May 18, 2017

@k8s-bot kubemark e2e test this

@enisoc
Copy link
Member Author

enisoc commented May 19, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@k8s-ci-robot
Copy link
Contributor

@enisoc: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 5792b15 link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enisoc enisoc merged commit 1537e9f into kubernetes:release-1.6.3 May 19, 2017
@enisoc enisoc deleted the eviction-1.6.3 branch May 19, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@feiskyer feiskyer

@yifan-gu yifan-gu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@enisoc @k8s-github-robot @k8s-ci-robot @feiskyer @yifan-gu @dashpole