Remove the numbered shell scripts from the live update example and the update.sh e2e test. #4573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update.sh e2e test. They were needlessly obfuscating the actual kubectl commands being run.
roberthbailey
force-pushed
the
update-sh
branch
from
c433af7 to
e0cc7b4
Compare
|
LGTM. |
j3ffml
added a commit
that referenced
this pull request
Feb 19, 2015
Remove the numbered shell scripts from the live update example and the update.sh e2e test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were needlessly obfuscating the actual kubectl commands being run.
This is the first step towards #3694 which will make it easier to rewrite the test in go since the go code will just need to exec kubectl rather than a series of shell scripts.