Fix the e2e --times flag for running tests more than once #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ginkgo.RunSpecsWithDefaultAndCustomReporters(&passed, "Kubernetes e2e Suite", r) | ||
| for i := 0; i < times && passed; i++ { | ||
| ginkgo.RunSpecsWithDefaultAndCustomReporters(&passed, fmt.Sprintf("Kubernetes e2e Suite run %d of %d", i+1, times), r) | ||
| } |
There was a problem hiding this comment.
Hm. I don't think this would interact well with --report_dir, would it? (It would just overwrite the junit.xml).
There was a problem hiding this comment.
Fair point, it does look like the last one run will win. On the plus side, we stop doing new runs if we encounter an error, meaning that any reports that get overwritten will just be reports of successes.
I'd use a different reporter for each run (junit_%d.xml), but I imagine that existing consumers are dependent on the filename.
There was a problem hiding this comment.
You're actually safe. Jenkins is currently consuming junit*.xml in anticipation of the line 75 comment above.
a-robinson
force-pushed
the
e2e-times
branch
from
0525412 to
9f10f77
Compare
|
LGTM |
zmerlynn
added a commit
that referenced
this pull request
Feb 19, 2015
Fix the e2e --times flag for running tests more than once
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4555.
cc @fabioy