Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in ExecCommandParam #45440

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Fix typo in ExecCommandParam #45440

merged 1 commit into from
Jul 17, 2017
+4 −4

Conversation

verb
Copy link
Contributor

@verb verb commented May 5, 2017

What this PR does / why we need it: Makes ExecCommandParam look like all of the other "Param"s

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @verb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 5, 2017
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels May 5, 2017
@feiskyer
Copy link
Member

feiskyer commented May 6, 2017

Seems not fixed in all places. You could search ExecCommandParamm across the project, and see where it is used.

@verb verb force-pushed the nit-too-much-m branch from 9ca2660 to 5c9f492 Compare May 8, 2017 17:40
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2017
@verb
Copy link
Contributor Author

verb commented May 8, 2017 •
edited
Loading

@feiskyer whoops, I didn't quite understand the role of the staging directory. I've updated the commit to include every "ExecCommandParamm" included by git grep in the kubernetes repo. Let me know if there are other repos to check.

@verb
Copy link
Contributor Author

verb commented May 8, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2017
@verb
Copy link
Contributor Author

verb commented May 8, 2017

Now that I think about it, I guess "ExecCommandParamm" was released as part of the versioned API. Does that mean we have to keep the typo around indefinitely?

If so I'll fix the typo internally and leave an extra "ExecCommandParamm" constant in types.go

@feiskyer
Copy link
Member

/assign @lavalamp

cc/ @lavalamp @kubernetes/sig-api-machinery-api-reviews WDYT

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 19, 2017
@deads2k
Copy link
Contributor

deads2k commented May 22, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2017
@verb verb force-pushed the nit-too-much-m branch from 5c9f492 to 786e993 Compare July 14, 2017 13:56
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2017
@deads2k
Copy link
Contributor

deads2k commented Jul 17, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2017
@deads2k
Copy link
Contributor

deads2k commented Jul 17, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k, verb
We suggest the following additional approver: lavalamp

Assign the PR to them by writing /assign @lavalamp in a comment when ready.

Associated issue requirement bypassed by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2017
@deads2k
Copy link
Contributor

deads2k commented Jul 17, 2017

fixing a typo in the code (not the exposed value). approving

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49017, 45440, 48384, 45894, 48808)

@k8s-github-robot k8s-github-robot merged commit e0dcaa3 into kubernetes:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@feiskyer feiskyer

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@verb @k8s-reviewable @k8s-ci-robot @feiskyer @deads2k @k8s-github-robot @lavalamp