Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a few typos i ran into during setup #4543

Merged
merged 3 commits into from
Feb 18, 2015
Merged

Conversation

mattf
Copy link
Contributor

@mattf mattf commented Feb 18, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@yujuhong yujuhong self-assigned this Feb 18, 2015
@yujuhong
Copy link
Contributor

LGTM. Thanks for the PR! Could you sign the CLA so that I can merge the PR?

@a-robinson
Copy link
Contributor

I don't believe we should be making changes to Godeps packages. Fixes for those should go to the upstream repository (github.com/miekg/dns, in this case)

@yujuhong
Copy link
Contributor

@a-robinson, uhh you're right. The file paths escaped my eye. The rest of the (non-Godeps) changes look good.

@mattf
Copy link
Contributor Author

mattf commented Feb 18, 2015

fyi - miekg/dns#182

@mattf
Copy link
Contributor Author

mattf commented Feb 18, 2015

LGTM. Thanks for the PR! Could you sign the CLA so that I can merge the PR?

i work for red hat and should be covered by the corp cla, matt@redhat.com

yujuhong added a commit that referenced this pull request Feb 18, 2015
fix a few typos i ran into during setup
@yujuhong yujuhong merged commit 6bbde83 into kubernetes:master Feb 18, 2015
@mattf mattf mentioned this pull request Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants