This change is 

Is there no better way to do this? This image is going to get huge if it just accretes all FS types.

Unfortunately not that I know of if you're running kubelet in a container. You likely could separately distribute the binary / libs and mount into container from host, but that is particularly fragile.

There's been talk about supporting shipping kubelet dependencies separately (network/mount tools/etc) -- but nothing available currently as far as I'm aware.

@aaronlevy my thinking is that ceph-common doesnt belong inside hyperkube. Anyone who wants to use rbd volumes must ensure its installed using their puppet or other mechanisms

@krmayankk this would be for when the kubelet is run inside of a container - so that these mount tools are available within the container filesystem (like nfs, cifs, and glusterfs already are). To do this at runtime within the container (e.g. puppet or other mechanisms) would require something like:

docker run hyperkube /bin/bash apt-get update && apt-get install ceph-common && /hyperkube kubelet [...]

I agree that it's unfortunate that it expands the image size, but I don't believe there are good alternatives.

@zmerlynn so if we're going to close #46873 in favor of this older one, can we get this added? i'm with @aaronlevy (obviously solving the same issue, and also using with bootkube + ceph backend).

it's unfortunate this hasn't been looked at in a while. i know that things change with CSI, but would it still be ok to get this in as an interim solution? i can continue building my own custom image, but it would be a lot nicer to have one provided upstream.

Sorry for going quiet. I'm okay with this if we also file a bug to get rid of it. :)

@zmerlynn I can open an issue re removing this specifically, but there's more general discussion about removing mount tools (if that covers your desired outcome): kubernetes/community#589

Also, cc @ixdy - as I'm not sure if this is problematic for #48365

/lgtm
/approve

/approve no-issue

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaronlevy, zmerlynn

Associated issue requirement bypassed by: zmerlynn

The full list of commands accepted by this bot can be found here.

@aaronlevy I'll update #48365, thanks for the heads up!

/test pull-kubernetes-federation-e2e-gce

/test all

/retest

/retest

Automatic merge from submit-queue (batch tested with PRs 45040, 48960)