Adding guestbook example with latest json format for v1beta3 api #4460

sub-mod · 2015-02-16T18:38:00Z

Support guestbook example json files to work with v3 api

derekwaynecarr · 2015-02-16T21:53:49Z

Can I ask why this change is needed?

This basically means users will not be able to run this same example in another Kubernetes namespace. The kubectl client will insert the namespace value from the current-context when omitted in the file, but when present, it errors if the context differs.

I don't think we should do this change.

sub-mod · 2015-02-17T05:32:29Z

I was just trying to give a working example of guestbook with latest k8-code and v3 api.I couldn't find one with latest format which worked on v3 api.
These json files have the latest json format .I agree hardcoding "default" can cause problems in other namespace.I gave "default" as the namespace just as an example so that the files were complete with all the data.But it was not really required since namespace field value can be fetched from the URI.
btw I was using curl instead of kubectl.

If it is worth to have this example , I have updated the json files and removed the namespace field from all the files.Else please feel free to mark this PR as Closed with no change.

nikhiljindal · 2015-02-17T19:32:10Z

@derekwaynecarr: Can I assigne this to you?

bgrant0607 · 2015-02-18T23:36:54Z

We need a v1beta3 example. I'll take a look.

bgrant0607 · 2015-02-18T23:44:04Z

examples/guestbook/guestbook_ns/redis-master.json

@@ -0,0 +1,32 @@
+{
+    "apiVersion": "v1beta3",
+    "kind": "Pod",


redis-master should be a 1-pod replication controller. See #4267

bgrant0607 · 2015-02-19T01:08:17Z

Please look at #1603 and the other issues/PRs cited.

Also, I'd like to take advantage of kubectl's multi-object capabilities. At least all objects relating to a particular microservice (e.g., frontend) should be in the same file.

bgrant0607 · 2015-02-19T01:08:55Z

And we should add this to https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/examples_test.go

bgrant0607 · 2015-02-19T01:09:28Z

examples/guestbook/guestbook_ns/frontend-controller.json

+                "name": "frontend-controller",
+                "labels": {
+                    "name": "frontend",
+                    "uses": "redisslave,redis-master",


"uses" is not a pattern I want to endorse. Please remove it.

bgrant0607 · 2015-02-23T19:17:45Z

FYI, no email is sent when you push changes. You need to comment on the PR in order for someone to notice. Looking now.

bgrant0607 · 2015-02-23T19:18:31Z

examples/examples_test.go

@@ -115,6 +115,14 @@ func TestExampleObjectSchemas(t *testing.T) {
 			"redis-master-service":   &api.Service{},
 			"redis-slave-service":    &api.Service{},
 		},
+		"../examples/guestbook/guestbook_ns": {


You have renamed the example.

@bgrant0607 I have added it in a new folder called guestbook_ns.
If changes look good , I will merge with guestbook folder

@bgrant0607 please let me know if it looks ok?

You introduced the following directories:

examples/guestbook-go/guestbook-go_v3/ examples/guestbook/guestbook_ns/

They should be consistent. Also, the guestbook_ns example no longer uses namespace, and guestbook doesn't really need to be in the subdirectory names.

Both examples should be tested here.

I suggest creating v1beta3 subdirectories in each example, with a short README.md just stating that it's a v1beta3 version of the example, and explaining that v1beta3 needs to be enabled.

In a couple weeks we'll promote these to the top level and eliminate the v1beta1 examples.

sub-mod · 2015-02-23T21:49:05Z

@bgrant0607 I have made the changes, please let me know if it looks ok

bgrant0607 · 2015-02-23T22:24:45Z

examples/guestbook-go/v1beta3/guestbook-service.json

+        "port": 3000,
+        "containerPort": "http-server",
+        "protocol": "TCP",
+        "createExternalLoadBalancer": true,


We're not creating an external load balancer in the existing examples because it's not supported by all cloud providers.

bgrant0607 · 2015-02-23T22:32:23Z

examples/guestbook-go/v1beta3/guestbook-controller.json

+        },
+        "template": {
+            "metadata": {
+                "name": "guestbook",


I think this name is ignored:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/controller/replication_controller.go#L70

I'm guessing we're not validating that name isn't specified due to legacy v1beta1/2 support.

Can you confirm, @smarterclayton?

That is correct - argument for validating the versioned structs, not the internal.

On Feb 23, 2015, at 5:33 PM, Brian Grant notifications@github.com wrote:

In examples/guestbook-go/v1beta3/guestbook-controller.json:

"kind": "ReplicationController",

"apiVersion": "v1beta3",

"metadata": {

"name": "guestbook",

"labels": {

"name": "guestbook"

}

},

"spec": {

"replicas": 3,

"selector": {

"name": "guestbook"

},

"template": {

"metadata": {

"name": "guestbook",
I think this name is ignored:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/controller/replication_controller.go#L70

I'm guessing we're not validating that name isn't specified due to legacy v1beta1/2 support.

Can you confirm, @smarterclayton?

—
Reply to this email directly or view it on GitHub.

bgrant0607 · 2015-02-23T22:38:44Z

examples/guestbook-go/v1beta3/redis-master-controller.json

+                        "image": "gurpartap/redis",
+                        "ports": [
+                            {
+                                "name": "redis-server",


Please use the port names everywhere, or eliminate them everywhere.

If some of the port names are required, I'm ok with leaving them as is for now.

bgrant0607 · 2015-02-23T22:56:18Z

LGTM. Will merge on green. Thanks.

bgrant0607 · 2015-02-24T00:58:17Z

Shippable failures were 2 different flakes. Merging.

Adding guestbook example with latest json format for v1beta3 api

fgrzadkowski · 2015-03-04T16:28:05Z

examples/guestbook-go/v1beta3/README.md

+The web front end interacts with the redis master via javascript redis API calls.
+
+The v1beta3 API is not enabled by default. The kube-apiserver process needs to run with the --runtime_config=api/v1beta3 argument. Use the following command to enable it:
+$sudo sed -i 's|KUBE_API_ARGS="|KUBE_API_ARGS="--runtime_config=api/v1beta3 |' /etc/kubernetes/apiserver


This doesn't work for me. Where should I run it? On master? On my local machine?

add this in /etc/kubernetes/apiserver where apiserver is running
KUBE_API_ARGS="--runtime_config=api/v1beta3"

Adding guestbook example with namespace

3f2553f

Removing namespace from json files

2cc5dd5

sub-mod changed the title ~~Adding guestbook example with namespace~~ Adding guestbook example with latest json format for v1beta3 api Feb 17, 2015

bgrant0607 self-assigned this Feb 18, 2015

bgrant0607 reviewed Feb 18, 2015
View reviewed changes

bgrant0607 reviewed Feb 19, 2015
View reviewed changes

sub-mod added 5 commits February 19, 2015 18:08

new changes

a749efa

json files updated

5aedf10

json files updated

3d7ca16

testcase updated

46c5862

add v3 json files for guesybook-go

027c1ac

erictune mentioned this pull request Feb 19, 2015

Remove HostPort conflict checking. #4619

Merged

bgrant0607 reviewed Feb 23, 2015
View reviewed changes

renaming folders

eb82df8

googlebot added the cla: yes label Feb 23, 2015

sub-mod added 3 commits February 24, 2015 02:54

updating testcases

23a177c

updating testcases

fd3d60f

renaming folder to v1beta3 and updating testcases

95c2255

bgrant0607 reviewed Feb 23, 2015
View reviewed changes

removing LoadBalancer

ea0a873

bgrant0607 reviewed Feb 23, 2015
View reviewed changes

removing name from template

62cb5b8

bgrant0607 reviewed Feb 23, 2015
View reviewed changes

format all json files

7d00c45

bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2015

bgrant0607 added a commit that referenced this pull request Feb 24, 2015

Merge pull request #4460 from sub-mod/guestbook_ns

754a2a8

Adding guestbook example with latest json format for v1beta3 api

bgrant0607 merged commit 754a2a8 into kubernetes:master Feb 24, 2015

sub-mod deleted the guestbook_ns branch February 25, 2015 21:10

fgrzadkowski reviewed Mar 4, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding guestbook example with latest json format for v1beta3 api #4460

Adding guestbook example with latest json format for v1beta3 api #4460

sub-mod commented Feb 16, 2015

derekwaynecarr commented Feb 16, 2015

sub-mod commented Feb 17, 2015

nikhiljindal commented Feb 17, 2015

bgrant0607 commented Feb 18, 2015

bgrant0607 Feb 18, 2015

bgrant0607 commented Feb 19, 2015

bgrant0607 commented Feb 19, 2015

bgrant0607 Feb 19, 2015

bgrant0607 commented Feb 23, 2015

bgrant0607 Feb 23, 2015

sub-mod Feb 23, 2015

sub-mod Feb 23, 2015

bgrant0607 Feb 23, 2015

bgrant0607 Feb 23, 2015

sub-mod commented Feb 23, 2015

bgrant0607 Feb 23, 2015

bgrant0607 Feb 23, 2015

smarterclayton Feb 23, 2015

bgrant0607 Feb 23, 2015

bgrant0607 Feb 23, 2015

bgrant0607 commented Feb 23, 2015

bgrant0607 commented Feb 24, 2015

fgrzadkowski Mar 4, 2015

sub-mod Mar 4, 2015

Adding guestbook example with latest json format for v1beta3 api #4460

Adding guestbook example with latest json format for v1beta3 api #4460

Conversation

sub-mod commented Feb 16, 2015

derekwaynecarr commented Feb 16, 2015

sub-mod commented Feb 17, 2015

nikhiljindal commented Feb 17, 2015

bgrant0607 commented Feb 18, 2015

Choose a reason for hiding this comment

bgrant0607 commented Feb 19, 2015

bgrant0607 commented Feb 19, 2015

Choose a reason for hiding this comment

bgrant0607 commented Feb 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sub-mod commented Feb 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bgrant0607 commented Feb 23, 2015

bgrant0607 commented Feb 24, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment