Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GetClientsetForCluster() #44545

Merged
merged 1 commit into from
May 2, 2017
Merged

Remove GetClientsetForCluster() #44545

merged 1 commit into from
May 2, 2017

Conversation

FengyunPan
Copy link

The newClusterClientset() has insteaded of GetClientsetForCluster(),
and GetClientsetForCluster() run wrong. Let's remove it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Apr 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @FengyunPan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 17, 2017
@FengyunPan
Copy link
Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 17, 2017
@ghost
Copy link

ghost commented Apr 18, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2017
@ghost
Copy link

ghost commented Apr 18, 2017

Thanks @FengyunPan
I'm happy to remove this function if it's truly unused, but a quick search suggests that it's still being referenced?

https://github.com/kubernetes/kubernetes/search?utf8=%E2%9C%93&q=GetClientSetForCluster&type=

@FengyunPan FengyunPan force-pushed the remove-GetClientsetForCluster branch from 0824966 to c44eb82 Compare April 18, 2017 02:10
@FengyunPan
Copy link
Author

Sorry, I can't find where it's still being referenced.
And the 'if err != nil && clusterConfig != nil' is wrong, it should be 'if err == nil && clusterConfig != nil'

@FengyunPan
Copy link
Author

@k8s-bot bazel test this
@k8s-bot cvm gce e2e test this

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2017
Remove incorrect and unused function
2077a5c 
The newClusterClientset() has insteaded of GetClientsetForCluster(),
and GetClientsetForCluster() run wrong. Let's remove it.
@FengyunPan FengyunPan force-pushed the remove-GetClientsetForCluster branch from c44eb82 to 2077a5c Compare April 27, 2017 01:53
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2017
@ghost
Copy link

ghost commented May 1, 2017 •
edited by ghost
Loading

@FengyunPan Did you try the link I posted above. The function is referenced in:

federation/pkg/federation-controller/util/federated_updater_test.go
federation/pkg/federation-controller/util/federated_informer.go
federation/pkg/federation-controller/util/federated_updater.go

@ghost
Copy link

ghost commented May 1, 2017

@FengyunPan never mind, I see that those are not real references to the function that you're removing.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FengyunPan, quinton-hoole

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2017
@FengyunPan
Copy link
Author

@k8s-bot gce etcd3 e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8f6df26 into kubernetes:master May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@madhusudancs madhusudancs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FengyunPan @k8s-reviewable @k8s-ci-robot @k8s-github-robot @madhusudancs