Simplify usage of os/exec #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, keep the finishRunning() wrapper but use a straight cmd.Run() call instead of the convoluted goroutine trying to catch signals. It turns out that Unix process group handling is enough to interrupt pending processes when stopping the run with something like a Ctrl+C which should be enough. Tested: - Full e2e run with hack/e2e-test.sh, two tests failed but looks like they've been failing before this change. - Started a hack/e2e.go -v -build and interrupted it with Ctrl+C, confirmed that build-release.sh was killed in the process.
satnam6502
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, keep the
finishRunning()wrapper but use a straightcmd.Run()call instead of the convoluted goroutine trying to catch signals.It turns out that Unix process group handling is enough to interrupt pending processes when stopping the run with something like a Ctrl+C which should be enough.
Tested:
hack/e2e-test.sh, two tests failed but looks like they've been failing before this change.hack/e2e.go -v -buildand interrupted it with Ctrl+C, confirmed thatbuild-release.shwas killed in the process.@satnam6502 @zmerlynn