Add an event for health check failures. #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1077,6 +1077,12 @@ func (kl *Kubelet) syncPod(pod *api.BoundPod, dockerContainers dockertools.Docke | |||
| containersToKeep[containerID] = empty{} | |||
| continue | |||
| } | |||
| ref, ok := kl.getRef(containerID) | |||
| if !ok { | |||
| glog.Warningf("No ref for pod '%v' - '%v'", ID, name) | |||
There was a problem hiding this comment.
This can't possibly even compile.
There was a problem hiding this comment.
I blame copy and paste. fixed.
|
comments addressed. ptal. |
| if !ok { | ||
| glog.Warningf("No ref for pod '%v' - '%v'", ID, name) | ||
| } else { | ||
| record.Eventf(ref, "unhealthy", "Health Check Failed %v - %v", ID, name) |
There was a problem hiding this comment.
Please don't use the term "Health Check". We now have both liveness and readiness probes in the API. You're reporting that the liveness probe failed.
|
Please see my now-hidden comment: #4408 (comment) |
brendandburns
force-pushed
the
printing
branch
from
678ab31
to
5e49a60
Compare
|
oops, comments crossed paths on the wire. addressed. |
|
LGTM |
bgrant0607
added
the
lgtm
saad-ali
added a commit
that referenced
this pull request
Feb 13, 2015
Add an event for health check failures.
|
@brendandburns Out of an abundance of caution I reverted this change because it caused v1.3 to fail on both Shippable and Travis. Rerunning, Travis is green, but Shippable v1.3 is still failing. The error seems transient. Could you squash the commits and resubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.